[GitHub] [fineract] adamsaghy commented on a diff in pull request #2601: FINERACT-1724: Add disallowExpectedDisbursements flag in Loan account response

[GitBox <gi...@apache.org>]

adamsaghy commented on code in PR #2601:
URL: https://github.com/apache/fineract/pull/2601#discussion_r970090516


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -1307,10 +1299,6 @@ public static LoanAccountData associationsAndTemplate(final LoanAccountData acc,
             final PaidInAdvanceData paidInAdvance, Collection<InterestRatePeriodData> interestRatesPeriods,
             final Collection<LoanAccountSummaryData> clientActiveLoanOptions, final List<RateData> rates, final Boolean isRatesEnabled,
             final CollectionData delinquent) {
-        LoanProductConfigurableAttributes loanProductConfigurableAttributes = null;

Review Comment:
   is there a reason to remove these?



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java:
##########
@@ -1080,9 +1074,6 @@ public static LoanAccountData loanProductWithTemplateDefaults(final LoanProductD
         final PaidInAdvanceData paidInAdvance = null;
         final Collection<InterestRatePeriodData> interestRatesPeriods = null;
 
-        final Boolean isVariableInstallmentsAllowed = Boolean.FALSE;

Review Comment:
   is there a reason to remove these?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org