You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/05/14 15:53:06 UTC
[Issue 124896] New: remove obsoleted module-internal custom
allocator in SAL
https://issues.apache.org/ooo/show_bug.cgi?id=124896
Issue ID: 124896
Issue Type: TASK
Summary: remove obsoleted module-internal custom allocator in
SAL
Product: General
Version: 4.1.0
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Priority: P3
Component: code
Assignee: issues@openoffice.apache.org
Reporter: hdu@apache.org
Depends on: 122362
The SAL module avoided the heavy dependency on the stlport4-libraries by using
a custom allocator for its internal STL containers. With issue 122362 stlport4
and these dependencies are gone, so the SAL-internal custom allocator is
obsoleted.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
Steve Yin <st...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |steve.yin.aoo@gmail.com
--- Comment #3 from Steve Yin <st...@gmail.com> ---
Hi Herbert. I got a build error on Windows which shows:
build -- version: 275224
=============
Building module sal
=============
Entering /cygdrive/d/Apache/trunk/openoffice/main/sal/inc
Entering /cygdrive/d/Apache/trunk/openoffice/main/sal/osl/w32
dmake: Error: -- `../../inc/rtl/allocator.hxx' not found, and can't be made
ERROR: error 65280 occurred while making
/cygdrive/d/Apache/trunk/openoffice/main/sal/osl/w32
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
Assignee|issues@openoffice.apache.or |hdu@apache.org
|g |
--- Comment #1 from hdu@apache.org <hd...@apache.org> ---
Since the obsolete allocator also results in tricky build problems (e.g.
attachment 82857) the removal solves these troubles too.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #8 from SVN Robot <sv...@dev.null.org> ---
"steve_y" committed SVN revision 1595419 into trunk:
i124896 add including of rtl/alloc.h in path_helper.hxx for win32
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.2.0 |4.1.1
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fanyuzhen@gmail.com
--- Comment #12 from fanyuzhen@gmail.com ---
It's verified fixed on Windows via build level testing
--
You are receiving this mail because:
You are watching all issue changes.
4.1.1_release_blocker granted: [Issue 124896] remove obsoleted
module-internal custom allocator in SAL
Posted by bu...@apache.org.
jsc@apache.org has granted 4.1.1_release_blocker:
Issue 124896: remove obsoleted module-internal custom allocator in SAL
https://issues.apache.org/ooo/show_bug.cgi?id=124896
------- Additional Comments from jsc@apache.org
grant showstopper flag for AOO 4.1.1
changes are necessary to build the branch on 10.9.x and Xcode 5.1
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #6 from Steve Yin <st...@gmail.com> ---
Hi Herbert. I tried to make a clean build by your suggestion. And some other
build errors occurred.
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(77) : error C2039: 'Allocator'
: is not a member of 'rtl'
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(77) : error C2065: 'Allocator'
: undeclared identifier
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(77) : error C2275: 'WCHAR' :
illegal use of this type as an expression
D:/Apache/BuildTools/MSSDK_v6.1/include\winnt.h(337) : see declaration
of 'WCHAR'
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(77) : error C2143: syntax
error : missing ';' before '>'
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(77) : error C2143: syntax
error : missing ';' before '>'
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(79) : error C2065: 'vec' :
undeclared identifier
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(82) : error C2065: 'vec' :
undeclared identifier
D:/Apache/openoffice/main/sal/osl/w32/module.cxx(85) : error C2065: 'vec' :
undeclared identifier
dmake: Error code 2, while making '../../wntmsci12.pro/obj/module.obj'
ERROR: error 65280 occurred while making
/cygdrive/d/Apache/openoffice/main/sal/osl/w32
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kschenk@apache.org
--- Comment #13 from Kay <ks...@apache.org> ---
Verified fixed on r1608485, Linux-32. Builds OK.
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.2.0
--- Comment #9 from hdu@apache.org <hd...@apache.org> ---
Fixed with the commits above. Thanks Steve.
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #2 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1594842 into trunk:
#i124896# remove obsoleted sal-module-internal custom STL allocator
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
Steve Yin <st...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #14 from Steve Yin <st...@gmail.com> ---
Verified on r1611634, Mac OS 10.7.5
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #11 from SVN Robot <sv...@dev.null.org> ---
"jsc" committed SVN revision 1602187 into branches/AOO410:
#124896# merge changes from trunk to be able to build on macos 10.9.3 and
Xco...
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #5 from hdu@apache.org <hd...@apache.org> ---
self-reminder: With all AOO internal users of rtl/allocator gone and no known
external users of it, there is no more need for allocator.hxx. Since it used to
be shipped in the SDK we'll have to note this in the release notes. Or to
reintroduce the obsolete file just to ship it with the SDK.
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #4 from hdu@apache.org <hd...@apache.org> ---
(In reply to Steve Yin from comment #3)
> dmake: Error: -- `../../inc/rtl/allocator.hxx' not found, and can't be made
This looks like a bad dependency in you build. The file allocator.hxx is not
used anymore, so dmake can only know about this header by a former dependency
analysis. Please run
fgrep allocator.hxx main/sal
to confirm this. Then remove sal's output directory or better make a clean
build.
FWIW issue 124903 mentioned a similar problem with obsoleted dependencies. Have
there been any changes to the build system that would impact the dependency
analysis?
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1595333 into trunk:
#i124896# use default allocator for w32 ShortPathName buffer
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |124908
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124896] remove obsoleted module-internal custom allocator in
SAL
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124896
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags| |4.1.1_release_blocker+
--- Comment #10 from jsc@apache.org ---
grant showstopper flag for AOO 4.1.1
changes are necessary to build the branch on 10.9.x and Xcode 5.1
--
You are receiving this mail because:
You are watching all issue changes.