You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 12:04:10 UTC

[GitHub] [flink] wangyang0918 opened a new pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

wangyang0918 opened a new pull request #12245:
URL: https://github.com/apache/flink/pull/12245


   Add document for K8s application mode.
   * How to start a Flink application
   * How to stop a Flink application


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630775448


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 33854044f5221540a2562043721b69356538c84c (Fri Oct 16 10:51:08 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865",
       "triggerID" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33854044f5221540a2562043721b69356538c84c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1875",
       "triggerID" : "33854044f5221540a2562043721b69356538c84c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f2223f4babaa1a562b680e69d9dc640eeeecf992 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865) 
   * ee77e27e788849971cd7fc6b13b8140e5c66013d UNKNOWN
   * 33854044f5221540a2562043721b69356538c84c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1875) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865",
       "triggerID" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846) 
   * f2223f4babaa1a562b680e69d9dc640eeeecf992 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865",
       "triggerID" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846) 
   * f2223f4babaa1a562b680e69d9dc640eeeecf992 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865) 
   * ee77e27e788849971cd7fc6b13b8140e5c66013d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman closed pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #12245:
URL: https://github.com/apache/flink/pull/12245


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman commented on a change in pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #12245:
URL: https://github.com/apache/flink/pull/12245#discussion_r427326471



##########
File path: docs/ops/deployment/native_kubernetes.md
##########
@@ -170,6 +170,34 @@ appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p %-60c %x - %m
 
 If the pod is running, you can use `kubectl exec -it <PodName> bash` to tunnel in and view the logs or debug the process.
 
+## Flink Kubernetes Application
+
+### Start Flink Application
+
+Use the following command to start a Flink application.
+{% highlight bash %}
+$ ./bin/flink run-application -p 8 -t kubernetes-application \
+  -Dkubernetes.cluster-id=<ClusterId> \
+  -Dtaskmanager.memory.process.size=4096m \
+  -Dkubernetes.taskmanager.cpu=2 \
+  -Dtaskmanager.numberOfTaskSlots=4 \
+  -Dkubernetes.container.image=<custom_image_name> \
+  local:///opt/flink/examples/streaming/WindowJoin.jar
+{% endhighlight %}
+
+Note: When deploying a Flink application, the user main code will be executed on Flink Master in the cluster. So the user jars and dependencies should already exist in the image. Follow the [how to customize the Flink Docker image](docker.html#customize-flink-image) to build a customized image baked in user jars on top of Flink official image.

Review comment:
       This needs to go on line 176 above the bash command. I'd also like to show a minimal dockerfile example. 
   
   ```suggestion
   Application mode allows users to create a single image containing their Job and the Flink runtime, which will automatically create and destroy cluster components as needed. The Flink community provides base docker images [customized](docker.html#customize-flink-image) for any use case.
   
   {% highlight dockerfile %}
   FROM flink
   COPY /target/my-flink-job-*.jar $FLINK_HOME/usrlib/my-flink-job.jar
   {% endhighlight %}
   ```

##########
File path: docs/ops/deployment/native_kubernetes.md
##########
@@ -170,6 +170,34 @@ appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p %-60c %x - %m
 
 If the pod is running, you can use `kubectl exec -it <PodName> bash` to tunnel in and view the logs or debug the process.
 
+## Flink Kubernetes Application
+
+### Start Flink Application
+
+Use the following command to start a Flink application.
+{% highlight bash %}
+$ ./bin/flink run-application -p 8 -t kubernetes-application \
+  -Dkubernetes.cluster-id=<ClusterId> \
+  -Dtaskmanager.memory.process.size=4096m \
+  -Dkubernetes.taskmanager.cpu=2 \
+  -Dtaskmanager.numberOfTaskSlots=4 \
+  -Dkubernetes.container.image=<custom_image_name> \
+  local:///opt/flink/examples/streaming/WindowJoin.jar
+{% endhighlight %}
+
+Note: When deploying a Flink application, the user main code will be executed on Flink Master in the cluster. So the user jars and dependencies should already exist in the image. Follow the [how to customize the Flink Docker image](docker.html#customize-flink-image) to build a customized image baked in user jars on top of Flink official image.
+
+Note: Only "local" is supported as schema for application mode. This assumes that the jar is located in the image, not the Flink client.
+
+Note: All the jars in the "$FLINK_HOME/usrlib" directory in the image will be added to user classpath.
+
+### Stop Flink Application
+
+When all the jobs in the application finished, the Flink cluster will be destroyed automatically. Also you could cancel all the Flink jobs to stop the application via cli or web dashboard.

Review comment:
       ```suggestion
   When an application is stopped, all Flink cluster resources are automatically destroyed.
   As always, Jobs may stop when manually canceled or, in the case of bounded Jobs, complete. 
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman commented on a change in pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #12245:
URL: https://github.com/apache/flink/pull/12245#discussion_r427324527



##########
File path: docs/ops/deployment/native_kubernetes.md
##########
@@ -170,6 +170,34 @@ appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p %-60c %x - %m
 
 If the pod is running, you can use `kubectl exec -it <PodName> bash` to tunnel in and view the logs or debug the process.
 
+## Flink Kubernetes Application
+
+### Start Flink Application
+
+Use the following command to start a Flink application.
+{% highlight bash %}
+$ ./bin/flink run-application -p 8 -t kubernetes-application \
+  -Dkubernetes.cluster-id=<ClusterId> \
+  -Dtaskmanager.memory.process.size=4096m \
+  -Dkubernetes.taskmanager.cpu=2 \
+  -Dtaskmanager.numberOfTaskSlots=4 \
+  -Dkubernetes.container.image=<custom_image_name>
+  local:///opt/flink/examples/streaming/WindowJoin.jar
+{% endhighlight %}
+
+Note: When deploying a Flink application, the user main code will be executed on Flink Master in the cluster. So the user jars and dependencies should already exist in the image. Follow the [how to customize the Flink Docker image](docker.html#customize-flink-image) to build a customized image baked in user jars on top of Flink official image.
+

Review comment:
       This needs to go on line 176 above the bash command. I'd also like to show a minimal dockerfile example. 
   
   ```suggestion
   Application mode allows users to create a single image containing their Job and the Flink runtime, which will automatically create and destroy cluster components as needed. The Flink community provides base docker images [customized](docker.html#customize-flink-image) for any use case.
   
   {% highlight dockerfile %}
   FROM flink
   
   COPY /target/my-flink-job-*.jar /opt/flink/usrlib/my-flink-job.jar
   {% endhighlight %}
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630877609


   @sjwiesman Thanks a lot for your review, especially for the text. I have integrated your suggestions and make some small change. Adding a line `RUN mkdir -p $FLINK_HOME/usrlib` in Dockerfile since in the current Flink release image it does not exist.
   
   I also create a ticket for the translation FLINK-17814. I will do it in the following days.
   
   Please have another look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846) 
   * f2223f4babaa1a562b680e69d9dc640eeeecf992 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865",
       "triggerID" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33854044f5221540a2562043721b69356538c84c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1875",
       "triggerID" : "33854044f5221540a2562043721b69356538c84c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846) 
   * f2223f4babaa1a562b680e69d9dc640eeeecf992 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865) 
   * ee77e27e788849971cd7fc6b13b8140e5c66013d UNKNOWN
   * 33854044f5221540a2562043721b69356538c84c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1875) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630775448


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e25645e9f745c1ca5134824263e36644620c884f (Tue May 19 12:06:40 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17810).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-630784890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846",
       "triggerID" : "e695add3318a20fda1d2d1336ab6ebf68b90a35a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865",
       "triggerID" : "f2223f4babaa1a562b680e69d9dc640eeeecf992",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ee77e27e788849971cd7fc6b13b8140e5c66013d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33854044f5221540a2562043721b69356538c84c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33854044f5221540a2562043721b69356538c84c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e695add3318a20fda1d2d1336ab6ebf68b90a35a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1846) 
   * f2223f4babaa1a562b680e69d9dc640eeeecf992 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1865) 
   * ee77e27e788849971cd7fc6b13b8140e5c66013d UNKNOWN
   * 33854044f5221540a2562043721b69356538c84c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman commented on pull request #12245: [FLINK-17810][doc] Add document for K8s application mode

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #12245:
URL: https://github.com/apache/flink/pull/12245#issuecomment-631055823


   Fixed in 7723774a0402e10bc914b1fa6128e3c80678dafe


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org