You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/22 10:20:52 UTC

[GitHub] [flink] zentol opened a new pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting 

zentol opened a new pull request #17852:
URL: https://github.com/apache/flink/pull/17852


   The setting had no effect since Java 8 and is actively rejected in Java 17.
   The remainder of the `argLine` parameter seemed unnecessary as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17852:
URL: https://github.com/apache/flink/pull/17852#issuecomment-975375312


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b682e7f99a4683feaaa34e337e808a400c5c43d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26824",
       "triggerID" : "6b682e7f99a4683feaaa34e337e808a400c5c43d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b682e7f99a4683feaaa34e337e808a400c5c43d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26824) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17852:
URL: https://github.com/apache/flink/pull/17852#issuecomment-975374383


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6b682e7f99a4683feaaa34e337e808a400c5c43d (Mon Nov 22 10:25:02 UTC 2021)
   
   **Warnings:**
    * **2 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17852:
URL: https://github.com/apache/flink/pull/17852#issuecomment-975375312


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b682e7f99a4683feaaa34e337e808a400c5c43d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6b682e7f99a4683feaaa34e337e808a400c5c43d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b682e7f99a4683feaaa34e337e808a400c5c43d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol edited a comment on pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #17852:
URL: https://github.com/apache/flink/pull/17852#issuecomment-976661587


   > Can we run into situations now where the fork number is not set when generating the logs?
   
   No, because mvn.forkNumber is still set in the root pom surefire configuration.
   
   > Why does [-Dmvn.forkNumber... ] not have any effect?
   
   It does, but we can use use the configuration from the root pom.
   
   > What happens to the expression ${sys:mvn.forkNumber} if the variable is not set? Will it stay like this verbatim?
   
   yes. You can actually find such a file in the azure artifacts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #17852:
URL: https://github.com/apache/flink/pull/17852#issuecomment-976661587


   > Can we run into situations now where the fork number is not set when generating the logs?
   
   No, because mvn.forkNumber is still set in the root pom surefire configuration.
   
   > What happens to the expression ${sys:mvn.forkNumber} if the variable is not set? Will it stay like this verbatim?
   
   yes. You can actually find such a file in the azure artifacts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17852:
URL: https://github.com/apache/flink/pull/17852#issuecomment-975375312


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b682e7f99a4683feaaa34e337e808a400c5c43d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26824",
       "triggerID" : "6b682e7f99a4683feaaa34e337e808a400c5c43d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b682e7f99a4683feaaa34e337e808a400c5c43d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26824) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #17852: [FLINK-24979][build][hbase] Remove MaxPermSize setting

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17852:
URL: https://github.com/apache/flink/pull/17852


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org