You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/19 10:30:09 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15175: [feature](new file reader) Integrate new file reader

github-actions[bot] commented on code in PR #15175:
URL: https://github.com/apache/doris/pull/15175#discussion_r1052044105


##########
be/src/vec/exec/format/parquet/parquet_thrift_util.h:
##########
@@ -33,12 +34,14 @@ namespace doris::vectorized {
 constexpr uint8_t PARQUET_VERSION_NUMBER[4] = {'P', 'A', 'R', '1'};
 constexpr uint32_t PARQUET_FOOTER_SIZE = 8;
 
-static Status parse_thrift_footer(FileReader* file, std::shared_ptr<FileMetaData>& file_metadata) {
+static Status parse_thrift_footer(io::FileReaderSPtr file,

Review Comment:
   warning: unused function 'parse_thrift_footer' [clang-diagnostic-unused-function]
   ```cpp
   static Status parse_thrift_footer(io::FileReaderSPtr file,
                 ^
   ```
   



##########
be/test/exec/plain_text_line_reader_bzip_test.cpp:
##########
@@ -37,16 +37,17 @@ class PlainTextLineReaderTest : public testing::Test {
 };
 
 TEST_F(PlainTextLineReaderTest, bzip2_normal_use) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/test_file.csv.bz2",
-                                0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file(
+            "./be/test/exec/test_data/plain_text_line_reader/test_file.csv.bz2", &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::BZIP2, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_bzip_test.cpp:35:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_bzip_test.cpp:
##########
@@ -89,15 +90,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, bzip2_test_limit) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::BZIP2, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 8, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_bzip_test.cpp:35:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_bzip_test.cpp:
##########
@@ -150,15 +155,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, bzip2_test_limit3) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::BZIP2, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_bzip_test.cpp:35:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_bzip_test.cpp:
##########
@@ -180,15 +187,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, bzip2_test_limit4) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::BZIP2, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_bzip_test.cpp:35:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -186,15 +194,17 @@
 }
 
 TEST_F(PlainTextLineReaderGzipTest, gzip_test_limit3) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -37,16 +39,17 @@ class PlainTextLineReaderGzipTest : public testing::Test {
 };
 
 TEST_F(PlainTextLineReaderGzipTest, gzip_normal_use) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/test_file.csv.gz",
-                                0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file(
+            "./be/test/exec/test_data/plain_text_line_reader/test_file.csv.gz", &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -161,15 +167,17 @@
 }
 
 TEST_F(PlainTextLineReaderGzipTest, gzip_test_limit2) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 6, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -125,15 +129,17 @@
 }
 
 TEST_F(PlainTextLineReaderGzipTest, gzip_test_limit) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 8, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lz4frame_test.cpp:
##########
@@ -210,15 +218,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lz4_test_limit5) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZ4FRAME, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 0, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 0, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 0, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lz4frame_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -216,15 +226,17 @@
 }
 
 TEST_F(PlainTextLineReaderGzipTest, gzip_test_limit4) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lz4frame_test.cpp:
##########
@@ -150,15 +154,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lz4_test_limit3) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZ4FRAME, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lz4frame_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -176,15 +182,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lzop_test_limit4) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lz4frame_test.cpp:
##########
@@ -126,15 +128,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lz4_test_limit2) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZ4FRAME, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 6, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lz4frame_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_bzip_test.cpp:
##########
@@ -126,15 +129,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, bzip2_test_limit2) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::BZIP2, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 6, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_bzip_test.cpp:35:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_bzip_test.cpp:
##########
@@ -210,15 +219,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, bzip2_test_limit5) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.bz2",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::BZIP2, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 0, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 0, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 0, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_bzip_test.cpp:35:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lz4frame_test.cpp:
##########
@@ -37,16 +36,17 @@ class PlainTextLineReaderTest : public testing::Test {
 };
 
 TEST_F(PlainTextLineReaderTest, lz4_normal_use) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/test_file.csv.lz4",
-                                0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file(
+            "./be/test/exec/test_data/plain_text_line_reader/test_file.csv.lz4", &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZ4FRAME, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lz4frame_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -124,15 +126,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lzop_test_limit2) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 6, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 6, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -246,15 +258,17 @@
 }
 
 TEST_F(PlainTextLineReaderGzipTest, gzip_test_limit5) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.gz",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 0, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 0, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 0, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_gzip_test.cpp:
##########
@@ -89,16 +92,17 @@
 }
 
 TEST_F(PlainTextLineReaderGzipTest, uncompressed_no_newline) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/no_newline.csv.gz",
-                                0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file(
+            "./be/test/exec/test_data/plain_text_line_reader/no_newline.csv.gz", &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::GZIP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderGzipTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_gzip_test.cpp:37:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -88,15 +88,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lzop_test_limit) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 8, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -37,16 +36,17 @@ class PlainTextLineReaderTest : public testing::Test {
 };
 
 TEST_F(PlainTextLineReaderTest, lzop_normal_use) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/test_file.csv.lzo",
-                                0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file(
+            "./be/test/exec/test_data/plain_text_line_reader/test_file.csv.lzo", &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, -1, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, -1, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lzop_test.cpp:
##########
@@ -147,15 +151,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lzop_test_limit3) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lzo",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZOP, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lzop_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lz4frame_test.cpp:
##########
@@ -89,15 +89,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lz4_test_limit) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZ4FRAME, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 8, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 8, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lz4frame_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



##########
be/test/exec/plain_text_line_reader_lz4frame_test.cpp:
##########
@@ -180,15 +186,17 @@
 }
 
 TEST_F(PlainTextLineReaderTest, lz4_test_limit4) {
-    LocalFileReader file_reader("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4", 0);
-    auto st = file_reader.open();
+    io::FileSystemSPtr local_fs = std::make_shared<io::LocalFileSystem>("");
+    io::FileReaderSPtr file_reader;
+    auto st = local_fs->open_file("./be/test/exec/test_data/plain_text_line_reader/limit.csv.lz4",
+                                  &file_reader);
     EXPECT_TRUE(st.ok());
 
     Decompressor* decompressor;
     st = Decompressor::create_decompressor(CompressType::LZ4FRAME, &decompressor);
     EXPECT_TRUE(st.ok());
 
-    PlainTextLineReader line_reader(&_profile, &file_reader, decompressor, 7, "\n", 1);
+    NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);

Review Comment:
   warning: '_profile' is a private member of 'doris::PlainTextLineReaderTest' [clang-diagnostic-error]
   ```cpp
       NewPlainTextLineReader line_reader(&_profile, file_reader, decompressor, 7, "\n", 1, 0);
                                           ^
   ```
   **be/test/exec/plain_text_line_reader_lz4frame_test.cpp:34:** declared private here
   ```cpp
       RuntimeProfile _profile;
                      ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org