[jira] [Commented] (GEODE-734) gfsh export stack-traces should not require an output file with extension .txt

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15699007#comment-15699007 ] 

ASF GitHub Bot commented on GEODE-734:
--------------------------------------

GitHub user deepakddixit opened a pull request:

    https://github.com/apache/incubator-geode/pull/297

     GEODE-734: gfsh export stack-traces should not require an output file with extension .txt

    Removed mandatory txt file extension when exporting stack trace using gfsh command export stack-traces.
    Added message warning user about possible overwrite of file if already present under locator directory.
    Added test to check if non txt extension file is allowed.
    All tests are passing

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-734

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit c64c69c84623bc40365961665f7c9c66793ea0c5
Author: Deepak Dixit <de...@gmail.com>
Date:   2016-11-26T13:41:52Z

     GEODE-734: Removing txt file restriction when exporting stack traces. Added message warning user about possible overwrite of file if already present.
      Added test to check if non txt extension file is allowed.

----


> gfsh export stack-traces should not require an output file with extension .txt
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-734
>                 URL: https://issues.apache.org/jira/browse/GEODE-734
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should have a user prompt indicating that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)