[GitHub] larroy commented on a change in pull request #11094: [MXNET-115] USE_LAPACK is forced on all platforms with OpenBLAS and c…

[GitBox <gi...@apache.org>]

larroy commented on a change in pull request #11094: [MXNET-115] USE_LAPACK is forced on all platforms with OpenBLAS and c…
URL: https://github.com/apache/incubator-mxnet/pull/11094#discussion_r191685343
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -363,17 +364,17 @@ elseif(UNIX)
   list(APPEND mxnet_LINKER_LIBS pthread)
 endif()
 
+
 # ---[ LAPack
-if(USE_LAPACK AND NOT MSVC)
+if(USE_LAPACK)
   add_definitions(-DMXNET_USE_LAPACK=1)
-  list(APPEND mxnet_LINKER_LIBS lapack)
-else(USE_LAPACK)
-  # Workaround for Windows until using new Jenkinsfile.
-  if(BLAS STREQUAL "Open" OR BLAS STREQUAL "open" OR USE_BLAS STREQUAL "Open" OR USE_BLAS STREQUAL "open")
-    add_definitions(-DMXNET_USE_LAPACK=1)
+  if (NOT MSVC)
+    list(APPEND mxnet_LINKER_LIBS lapack)
 
 Review comment:
   I don't get your comment, I tried to fix the logic as I understood the previous logic was working around adding these flags in the windows case and breaking other platforms. Can you elaborate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services