You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/05/12 07:37:56 UTC

[Apache Bloodhound] #65: Sticky panels in Bloodhound theme

#65: Sticky panels in Bloodhound theme
-------------------------+--------------------
 Reporter:  olemis       |      Owner:  nobody
     Type:  enhancement  |     Status:  new
 Priority:  major        |  Milestone:
Component:  ui design    |    Version:
 Keywords:  bootstrap    |
-------------------------+--------------------
 Implement sticky panels sketched in
 [https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
 templates/ mockups] .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-----------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-----------------------

Comment (by gjm):

 r1345024 adds the sticky bar as provided by olemis with minor differences.

 I re-inserted the #alert-log css rule and as there was much white space
 change I attempted to normalise some of the indentation (mostly reducing
 tab use).

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-----------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-----------------------

Comment (by olemis):

 [attachment:t65_r1343875_milestone_sticky.diff Attached patch] implements
 sticky panel for milestone view. It's built to be applied against r1343875
 . The solution (javascript, ...) differs substantially from the one
 provided in the mockups , mainly in spite of supporting more generic use
 cases (e.g. arbitrary widths , heights , different locations for target
 ''DIV'' , ...).

 Instructions provided in separate comment . Please read below .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-----------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-----------------------

Comment (by olemis):

 ==== Instructions to setup sticky panels ====

 Markup needed to insert sticky panels looks like shown below (assuming
 ''theme.js'' is included , included ootb if bloodhound theme is in use) :

 {{{
 #!xml

 <div class="stickyBox">
   <div id="panelId" class="stickyStatus">
     <div class="whitebox"></div>
     <!-- Panel contents -->
     <div class="stickyEndMark"></div>
   </div>
 </div>
 <script type="text/javascript">
   setup_sticky_panel('#panelId');
 </script>

 }}}

 ==== Sticky panel explained ====

 Panel `.stickyStatus` is the most important , as it contains the contents
 of sticky panel and actually remains fixed at `top=0` on page scroll.
 `.stickyBox` is a wrapper . It's goal is to substitute `.stickyStatus`
 when it becomes sticky, otherwise contents below will jump abruptly to the
 top. On the other hand `.whitebox` provides white background to hide
 contents moving below sticky panel. Nonetheless sometimes (e.g. floating
 elements) panel contents are rendered outside of the box and are visible ,
 thus creating an annoying overlapping effect . The goal of using
 `.stickyEndMark` is to control this kind of overflow . Code inside
 `script` tag at the bottom selects sticky element and installs scroll
 handlers , etc ... So far in each call it's recommended to select panels
 by ''ID'' or panels aligned in a row .

 '''PS:''' It's possible to simplify markup in templates by inserting all
 those ''DIV''s (except `.stickyStatus`) dynamically under the hood . In
 that case ''Genshi templates'' will be more readable and look better .
 Nonetheless , if this is a good idea I suggest to create a new ticket
 (enhancement) for this task. It may include also smarter behavior for use
 cases when more complex selectors are needed.

 '''PS:''' thnx jdreimman ... ''':)'''

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-----------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-----------------------

Comment (by gjm):

 Thanks for that Olemis.

 I note that the patch removes the #alert-log css rule. Whilst, with a very
 quick search of the source, this appears to apply to a commented out
 section of bloodhound_theme.html, was this intentional?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-----------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-----------------------
Changes (by olemis):

 * owner:  nobody => olemis
 * status:  new => accepted


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:  RC1 for initial release
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-------------------------------------
Changes (by olemis):

 * milestone:   => RC1 for initial release


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-----------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  major        |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  bootstrap
--------------------------+-----------------------

Comment (by olemis):

 Sticky panels in action

 [[Image(ticket:93:bh_theme_x_36_milestone_continuous_sticky.png,
 width=600)]]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #65: Sticky panels in Bloodhound theme

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#65: Sticky panels in Bloodhound theme
--------------------------+-------------------------------------
  Reporter:  olemis       |      Owner:  olemis
      Type:  enhancement  |     Status:  closed
  Priority:  major        |  Milestone:  RC1 for initial release
 Component:  ui design    |    Version:
Resolution:  fixed        |   Keywords:  bootstrap
--------------------------+-------------------------------------
Changes (by gjm):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 As the product version of this happened outside this ticket, I guess any
 more will just happen so I will close this for now.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/65#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker