You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/15 02:59:33 UTC

[GitHub] [incubator-devlake] warren830 opened a new pull request, #4420: fix(tapd): fix json tag for story and task

warren830 opened a new pull request, #4420:
URL: https://github.com/apache/incubator-devlake/pull/4420

   ### Summary
   This pr changed json tag for story and task model.
   Already fixed and tested in #4415 
   
   ### Does this close any open issues?
   Closes #4419 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] abeizn merged pull request #4420: fix(tapd): fix json tag for story and task

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #4420:
URL: https://github.com/apache/incubator-devlake/pull/4420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4420: fix(tapd): fix json tag for story and task

Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on code in PR #4420:
URL: https://github.com/apache/incubator-devlake/pull/4420#discussion_r1106600842


##########
backend/plugins/tapd/models/migrationscripts/archived/story.go:
##########
@@ -82,9 +82,9 @@ type TapdStory struct {
 	CustomFieldThree string `json:"custom_field_three" gorm:"type:text"`
 	CustomFieldFour  string `json:"custom_field_four" gorm:"type:text"`
 	CustomFieldFive  string `json:"custom_field_five" gorm:"type:text"`
-	CustomField6     string `json:"custom_field_6" gorm:"type:text"`
-	CustomField7     string `json:"custom_field_7" gorm:"type:text"`
-	CustomField8     string `json:"custom_field_8" gorm:"type:text"`
+	CustomField6     string `json:"custom_field_six" gorm:"type:text"`
+	CustomField7     string `json:"custom_field_seven" gorm:"type:text"`
+	CustomField8     string `json:"custom_field_eight" gorm:"type:text"`
 	CustomField9     string `json:"custom_field_9" gorm:"type:text"`

Review Comment:
   Nope~~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4420: fix(tapd): fix json tag for story and task

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4420:
URL: https://github.com/apache/incubator-devlake/pull/4420#discussion_r1106598574


##########
backend/plugins/tapd/models/migrationscripts/archived/story.go:
##########
@@ -82,9 +82,9 @@ type TapdStory struct {
 	CustomFieldThree string `json:"custom_field_three" gorm:"type:text"`
 	CustomFieldFour  string `json:"custom_field_four" gorm:"type:text"`
 	CustomFieldFive  string `json:"custom_field_five" gorm:"type:text"`
-	CustomField6     string `json:"custom_field_6" gorm:"type:text"`
-	CustomField7     string `json:"custom_field_7" gorm:"type:text"`
-	CustomField8     string `json:"custom_field_8" gorm:"type:text"`
+	CustomField6     string `json:"custom_field_six" gorm:"type:text"`
+	CustomField7     string `json:"custom_field_seven" gorm:"type:text"`
+	CustomField8     string `json:"custom_field_eight" gorm:"type:text"`
 	CustomField9     string `json:"custom_field_9" gorm:"type:text"`

Review Comment:
   9, 10, 11  need ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org