[GitHub] [incubator-nuttx] patacongo commented on pull request #3611: tools/kconfig2html.c: Add missing parse logic

[GitBox <gi...@apache.org>]

patacongo commented on pull request #3611:
URL: https://github.com/apache/incubator-nuttx/pull/3611#issuecomment-827920030


   > 
   > 
   > > File ./arch/risc-v/src/esp32c3/Kconfig Unhandled token: depends
   > 
   > This error is related to this `comment` command:
   > 
   > ```
   > comment "Selected ESP32-C3 chip without embedded Flash, an external Flash memory is required."
   > 	depends on ARCH_CHIP_ESP32C3X
   > ```
   > 
   > `arch/xtensa/src/esp32/Kconfig` contains a similar comment to let the user know why some options are hidden.
   
   Thanks.  I didn't look at all of the of `depends on` in the file.  When I new which one it was the fix was easy.  We talked about this in the past and decided not to support condition comments of that form, that is why it is not support.  The ones for the Expressif parts are inconsistent and the only cases where that form is used.  Those comments probably should be removed (I know the Linux community encourages that usage, but it has been discourage in NuttX for many years so any usage is inconsistent).
   
   BTW:  The other
   
       depends on ARCH_CHIP_ESP32C3
   
   are unnecessary and redundant since the Kconfig file begins with:
   
       if ARCH_CHIP_ESP32C3
   
   Everything from there to the matching endif has the that dependency.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org