You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/19 09:29:04 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #8613: Support enable WebSocket on Pulsar Proxy.

eolivelli commented on a change in pull request #8613:
URL: https://github.com/apache/pulsar/pull/8613#discussion_r526712948



##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/proxy/TestProxy.java
##########
@@ -53,6 +65,7 @@
         proxyViaURL = new ProxyContainer(clusterName, "proxy-via-url")
             .withEnv("brokerServiceURL", "pulsar://pulsar-broker-0:6650")
             .withEnv("brokerWebServiceURL", "http://pulsar-broker-0:8080")
+            .withEnv("webSocketServiceEnabled", "true")

Review comment:
       IIUC if we always enable websockets in this test we are losing to test the case in which websocket is disabled
   is it correct ?
   it would be better to have tests that cover default configurations together with tests that test additional features




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org