You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/15 21:36:03 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7601: Update -with-profile and add some profiling documentation
shinrich opened a new pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601#issuecomment-807825996
It seems like the three functions exist one the latest header file. Am I looking at an old version or a different file?
https://github.com/gperftools/gperftools/blob/master/src/gperftools/heap-profiler.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601#issuecomment-807077258
The symbols did not exist with the new header files. Probably different symbols. Since I was concentrating on CPU performance, I didn't track it down..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601#issuecomment-817208553
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601#issuecomment-801652556
Why was heap profiler removed? If we are going to remove it, can we remove the include line as well?
```
$ git grep gperftools
src/traffic_server/traffic_server.cc:#include <gperftools/profiler.h>
src/traffic_server/traffic_server.cc:#include <gperftools/heap-profiler.h>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601#issuecomment-809593309
Pushed another commit that added back the heap profiling calls. Built for me now. Don't now what was my problem before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7601: Update -with-profile and add some profiling documentation
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7601:
URL: https://github.com/apache/trafficserver/pull/7601#issuecomment-802302424
I would like to know why the heap profiler was remove also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org