You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 15:25:56 UTC
[GitHub] [flink] darenwkt opened a new pull request, #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
darenwkt opened a new pull request, #20186:
URL: https://github.com/apache/flink/pull/20186
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request adds error handling around OperatorCoordinatorHolder.start method, addressing problem raised in [FLINK-28411]. Previously, exception from this method (I.e from starting OperatorCoordinator) bubbles up to Dispatcher to trigger a fatal error which brings down the entire cluster. With this new change, OperatorCoordinatorHolder will instead trigger a globalFailure which is handled by the Scheduler.
## Brief change log
OperatorCoordinatorHolder.start now handles exception thrown from OperatorCoordinator.start. It rethrows the error if it's a JVM/OOM fatal error. Else, it triggers a globalFailure which is handled by Scheduler to attempt to restart the Job.
## Verifying this change
Added Unit Test to validate:
- Exception is caught and not bubbled up above OperatorCoordinatorHolder.
- GlobalFailure is successfully triggered.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #20186:
URL: https://github.com/apache/flink/pull/20186#issuecomment-1190508355
@darenwkt you have a CI failure on compilation step, can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] darenwkt commented on pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
Posted by GitBox <gi...@apache.org>.
darenwkt commented on PR #20186:
URL: https://github.com/apache/flink/pull/20186#issuecomment-1182455974
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a diff in pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #20186:
URL: https://github.com/apache/flink/pull/20186#discussion_r925835278
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolderTest.java:
##########
@@ -442,6 +442,25 @@ public void testCheckpointFailsIfSendingEventFailedBeforeTrigger() throws Except
assertTrue(checkpointResult.isCompletedExceptionally());
}
+ @Test
+ public void testFailJobWhenExceptionThrownFromStartingOperatorCoordinatorHolder()
+ throws Exception {
+ Function<OperatorCoordinator.Context, OperatorCoordinator> coordinatorProvider =
+ context ->
+ new TestingOperatorCoordinator(context) {
+ @Override
+ public void start() {
+ throw new RuntimeException("Artificial Exception");
+ }
+ };
+ final EventReceivingTasks tasks = EventReceivingTasks.createForRunningTasks();
+ final OperatorCoordinatorHolder holder =
+ createCoordinatorHolder(tasks, coordinatorProvider);
+
+ assertNotNull(globalFailure);
Review Comment:
Can you add an assertion to check that the job is cancelled with the appropriate error?
##########
mvnvm.properties:
##########
@@ -0,0 +1 @@
+mvn_version=3.2.5
Review Comment:
What is this for? This is an old maven version, looks like this is not intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] darenwkt closed pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
Posted by GitBox <gi...@apache.org>.
darenwkt closed pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
URL: https://github.com/apache/flink/pull/20186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20186:
URL: https://github.com/apache/flink/pull/20186#issuecomment-1176370651
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f323007c18ff9eb16ea5f9a48824fb880f06ad64",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f323007c18ff9eb16ea5f9a48824fb880f06ad64",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f323007c18ff9eb16ea5f9a48824fb880f06ad64 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org