You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 19:51:53 UTC

[GitHub] [airflow] dstandish commented on a change in pull request #19546: Track completed triggers until deleted from database

dstandish commented on a change in pull request #19546:
URL: https://github.com/apache/airflow/pull/19546#discussion_r765198334



##########
File path: airflow/jobs/triggerer_job.py
##########
@@ -315,6 +339,7 @@ async def cleanup_finished_triggers(self):
                         details["name"],
                     )
                     self.failed_triggers.append(trigger_id)
+                self.completed_triggers.add(trigger_id)

Review comment:
       @andrewgodwin gentle nudge here.  If you want to go with time-based expiration I have no objection and am happy to rework this.  I do recognize that my solution adds a query but if you don't mind explaining I'm having trouble seeingthe unbound growth.
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org