You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/17 04:23:40 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5244: board: Remove -fno-strict-aliasing and -fno-strength-reduce
xiaoxiang781216 opened a new pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#issuecomment-1015581887
@pkarashchenko Only this can apply the change:
https://github.com/apache/incubator-nuttx/pull/5244/files#diff-5231c6d2bc4bea5e569bd0bbf5d3d8cee0b1f4cfa6492bed180a07622ab0f2deR36
> @xiaoxiang781216 what is the problem of having `-fno-strength-reduce` with
>
> ```
> config DEBUG_NOOPT
> bool "Suppress Optimization"
> ---help---
> Build without optimization. This is often helpful when debugging code.
> ```
>
> ? Or you just want to say that strength reduction does not influence on debugging experience in general?
I am enabling clang toolchain, and the compiler emit a warning message for each source file since -fno-strength-reduce` doesn't support by clang yet. So, it's simple to remove this option from Make.defs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#discussion_r786926086
##########
File path: boards/renesas/m16c/skp16c26/scripts/Make.defs
##########
@@ -35,7 +35,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
can't since MAXOPTIMIZATION is defined in m16c(actually, arch/renesas forget to define Toolchain.defs at all).
##########
File path: boards/renesas/rx65n/rx65n-grrose/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
ditto
##########
File path: boards/renesas/rx65n/rx65n-rsk1mb/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
ditto
##########
File path: boards/renesas/rx65n/rx65n-rsk2mb/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#discussion_r786490453
##########
File path: boards/renesas/rx65n/rx65n-rsk1mb/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
```suggestion
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fomit-frame-pointer
```
##########
File path: boards/renesas/rx65n/rx65n-grrose/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
```suggestion
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fomit-frame-pointer
```
##########
File path: boards/renesas/rx65n/rx65n/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
```suggestion
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fomit-frame-pointer
```
##########
File path: boards/renesas/sh1/us7032evb1/scripts/Make.defs
##########
@@ -26,7 +26,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
```suggestion
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fomit-frame-pointer
```
##########
File path: boards/renesas/m16c/skp16c26/scripts/Make.defs
##########
@@ -35,7 +35,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
```suggestion
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fomit-frame-pointer
```
##########
File path: boards/renesas/rx65n/rx65n-rsk2mb/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
```suggestion
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fomit-frame-pointer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#discussion_r786926663
##########
File path: boards/renesas/rx65n/rx65n/scripts/Make.defs
##########
@@ -44,7 +44,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#issuecomment-1015917754
> > @pkarashchenko Only this can apply the change:
> > https://github.com/apache/incubator-nuttx/pull/5244/files#diff-5231c6d2bc4bea5e569bd0bbf5d3d8cee0b1f4cfa6492bed180a07622ab0f2deR36
> >
> >
> > > @xiaoxiang781216 what is the problem of having `-fno-strength-reduce` with
> > >
> > > ```
> > > config DEBUG_NOOPT
> > > bool "Suppress Optimization"
> > > ---help---
> > > Build without optimization. This is often helpful when debugging code.
> > > ```
> > >
> > > ? Or you just want to say that strength reduction does not influence on debugging experience in general?
> >
> > I am enabling clang toolchain, and the compiler emit a warning message for each source file since -fno-strength-reduce` doesn't support by clang yet. So, it's simple to remove this option from Make.defs.
>
> Understood. I think it is fine to remove it, but in general flags are different in GCC, Clang and IAR, so if we would like to support multiple compilers for the same target, then probably it is good to think about flags definition depending on selected compiler.
@xiaoxiang781216 the proper PR description would help to understand such changes better in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#issuecomment-1015617228
> @pkarashchenko Only this can apply the change:
> https://github.com/apache/incubator-nuttx/pull/5244/files#diff-5231c6d2bc4bea5e569bd0bbf5d3d8cee0b1f4cfa6492bed180a07622ab0f2deR36
>
>
> > @xiaoxiang781216 what is the problem of having `-fno-strength-reduce` with
> >
> > ```
> > config DEBUG_NOOPT
> > bool "Suppress Optimization"
> > ---help---
> > Build without optimization. This is often helpful when debugging code.
> > ```
> >
> > ? Or you just want to say that strength reduction does not influence on debugging experience in general?
>
> I am enabling clang toolchain, and the compiler emit a warning message for each source file since -fno-strength-reduce` doesn't support by clang yet. So, it's simple to remove this option from Make.defs.
Understood. I think it is fine to remove it, but in general flags are different in GCC, Clang and IAR, so if we would like to support multiple compilers for the same target, then probably it is good to think about flags definition depending on selected compiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#discussion_r786920489
##########
File path: boards/renesas/m16c/skp16c26/scripts/Make.defs
##########
@@ -35,7 +35,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#discussion_r786926835
##########
File path: boards/renesas/sh1/us7032evb1/scripts/Make.defs
##########
@@ -26,7 +26,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244#discussion_r786920489
##########
File path: boards/renesas/m16c/skp16c26/scripts/Make.defs
##########
@@ -35,7 +35,7 @@ ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
endif
ifneq ($(CONFIG_DEBUG_NOOPT),y)
- ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fno-strength-reduce -fomit-frame-pointer
+ ARCHOPTIMIZATION += -Os -fno-strict-aliasing -fomit-frame-pointer
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5244: board: Remove -fno-strength-reduce
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5244:
URL: https://github.com/apache/incubator-nuttx/pull/5244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org