You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/09/13 06:43:15 UTC
[GitHub] cordova-plugin-console pull request #25: CB-13170 - final changes and releas...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-plugin-console/pull/25
CB-13170 - final changes and release of post-integration cordova-plugin-console
### Platforms affected
cordova-ios, cordova-windows
### What does this PR do?
Prevent installation of this plugin on cordova-ios >= 4.5.0, and cordova-windows > 5.0.0
### What testing has been done on this change?
Added the plugin on different platform versions for the affected platforms.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-plugin-console CB-13170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-console/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 316d30b95471dae6f2b38cba9ffde4173014ea2b
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-09-13T06:39:14Z
CB-13170 - final changes and release of post-integration cordova-plugin-console
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
Travis tests are failing on Android for some reason that is unrelated to the code.
`"npm cache clean -f" failed`
@bowserj any insight? I'll close and re-open to rejigger things.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console pull request #25: CB-13170 - final changes and releas...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-plugin-console/pull/25
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console pull request #25: CB-13170 - final changes and releas...
Posted by shazron <gi...@git.apache.org>.
GitHub user shazron reopened a pull request:
https://github.com/apache/cordova-plugin-console/pull/25
CB-13170 - final changes and release of post-integration cordova-plugin-console
### Platforms affected
cordova-ios, cordova-windows
### What does this PR do?
Prevent installation of this plugin on cordova-ios >= 4.5.0, and cordova-windows > 5.0.0
### What testing has been done on this change?
Added the plugin on different platform versions for the affected platforms.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-plugin-console CB-13170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-console/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 316d30b95471dae6f2b38cba9ffde4173014ea2b
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-09-13T06:39:14Z
CB-13170 - final changes and release of post-integration cordova-plugin-console
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...
Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
Nice.
Does this mean that the 2.0.0 of the console plugin can be installed on `cordova-ios` 4.5.0 without causing the build problems?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console pull request #25: CB-13170 - final changes and releas...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-console/pull/25
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
thanks @alsorokin !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
Have no fear, the CI warden is on his post.
Please, rebase :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
@janpio Yes. I tested this on cordova-ios@4.5.0 and it skips installing the plugin, but installs on cordova-ios@4.4.0
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org