You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by lionelcao <gi...@git.apache.org> on 2017/08/21 06:44:12 UTC
[GitHub] carbondata pull request #1276: [CARBONDATA-1401] fix duplicate issue in List...
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1276
[CARBONDATA-1401] fix duplicate issue in ListInfo
add validation for listInfo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lionelcao/carbondata carbon1401
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1276
----
commit bd8048081933ab8fcbddcb9f6a64662d8d7ec90d
Author: lionelcao <wh...@gmail.com>
Date: 2017-08-21T06:43:35Z
fix duplicate issue in ListInfo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1276: [CARBONDATA-1401] fix duplicate issue in ListInfo
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1276
SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/277/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1276: [CARBONDATA-1401] fix duplicate issue in List...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1276#discussion_r134376168
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -369,6 +369,14 @@ object CommonUtil {
}
}
+ def validateListInfo(listInfo: List[List[String]]): Unit = {
--- End diff --
two more things:
1. this function is only used once, so I think there is no need to place it in `CommonUtil`.
2. is `distinct` case-sensitive or not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1276: [CARBONDATA-1401] fix duplicate issue in ListInfo
Posted by lionelcao <gi...@git.apache.org>.
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1276
@ravipesala Test case added，please verify.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1276: [CARBONDATA-1401] fix duplicate issue in List...
Posted by lionelcao <gi...@git.apache.org>.
Github user lionelcao closed the pull request at:
https://github.com/apache/carbondata/pull/1276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1276: [CARBONDATA-1401] fix duplicate issue in List...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1276#discussion_r134375904
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -369,6 +369,14 @@ object CommonUtil {
}
}
+ def validateListInfo(listInfo: List[List[String]]): Unit = {
--- End diff --
simplify this by
```
val list = listInfo.flatted
if (list.length != list.distinct.size) {
sys.error("xxx")
}
``
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1276: [CARBONDATA-1401] fix duplicate issue in List...
Posted by lionelcao <gi...@git.apache.org>.
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1276#discussion_r135380693
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -369,6 +369,14 @@ object CommonUtil {
}
}
+ def validateListInfo(listInfo: List[List[String]]): Unit = {
--- End diff --
Hi @xuchuanyin ,
Thank you for the comments. Have changed to use flatten function.
1. Put in CommonUtil not only for reusing but also keep code in one style and put similar function in one place.
2. distinct is case sensitive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1276: [CARBONDATA-1401] fix duplicate issue in ListInfo
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1276
SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/325/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1276: [CARBONDATA-1401] fix duplicate issue in ListInfo
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1276
I have merged but still not closed, Please close it manually
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1276: [CARBONDATA-1401] fix duplicate issue in ListInfo
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1276
@lionelcao Please add a testcase for this scenario
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1276: [CARBONDATA-1401] fix duplicate issue in ListInfo
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1276
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---