You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/02/03 17:33:59 UTC
[jira] Created: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Move shared state from AMQMessage to QueueEntry
-----------------------------------------------
Key: QPID-1628
URL: https://issues.apache.org/jira/browse/QPID-1628
Project: Qpid
Issue Type: Sub-task
Reporter: Martin Ritchie
Priority: Minor
Summary:
Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1628:
---------------------------------
Status: Ready To Review (was: In Progress)
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1628:
------------------------------------
Assignee: Martin Ritchie
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1628:
------------------------------------
Assignee: Aidan Skinner (was: Martin Ritchie)
Hi Aidan can you review this change please. I know there is a lot of file changes but redelivered was used in a lot of places. Mostly it is changing from AMQMessage to QueueEntry.
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1628:
---------------------------------
Status: Ready To Review (was: In Progress)
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1628:
------------------------------------
Assignee: Rob Godfrey (was: Aidan Skinner)
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rob Godfrey
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-1628:
--------------------------------
Assignee: Martin Ritchie (was: Aidan Skinner)
Status: Open (was: Ready To Review)
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/MessageHandleFactory.java has some commented out code, it should just be removed.
Looks ok otherwise.
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1628:
---------------------------------
Component/s: Java Broker
Fix Version/s: M5
Priority: Major (was: Minor)
Description:
Summary:
Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
was:
Summary:
Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
Affects Version/s: M4
Remaining Estimate: 2h
Original Estimate: 2h
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1628) Move shared state from AMQMessage to
QueueEntry
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1628:
------------------------------------
Assignee: Aidan Skinner (was: Martin Ritchie)
Hi Aidan, The MessageHandleFactory is now MessageFactory and should not have the commented out code.
> Move shared state from AMQMessage to QueueEntry
> -----------------------------------------------
>
> Key: QPID-1628
> URL: https://issues.apache.org/jira/browse/QPID-1628
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: M5
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Summary:
> Currently items such as redelivered exist on the AMQMessage object but these are actually part of the QueueEntry. All such state should be moved to the QueueEntry. AMQMessage should be stateless and only contain the message Header and Bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org