You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/08/10 13:17:18 UTC

DO NOT REPLY [Bug 49734] New: Null pointer exception on stop Threads command (Run>Stop)

https://issues.apache.org/bugzilla/show_bug.cgi?id=49734

           Summary: Null pointer exception on stop Threads command
                    (Run>Stop)
           Product: JMeter
           Version: 2.4
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: major
          Priority: P2
         Component: Main
        AssignedTo: notifications@jakarta.apache.org
        ReportedBy: stephane.hoblingre@gmail.com


Some times when asking jmeter to stop a running thread group a null pointer
exception is thrown and the window saying "Stopping Threads" remains displayed.
The exception is:
Exception in thread "Thread-357" java.lang.NullPointerException
    at
org.apache.jmeter.engine.StandardJMeterEngine.tellThreadsToStop(StandardJMeterEngine.java:542)
    at
org.apache.jmeter.engine.StandardJMeterEngine.access$700(StandardJMeterEngine.java:57)
    at
org.apache.jmeter.engine.StandardJMeterEngine$StopTest.run(StandardJMeterEngine.java:357)
    at java.lang.Thread.run(Unknown Source)

It seams a null check on the Thread object retreived should be done in this
method:

    private void tellThreadsToStop() {
        synchronized (allThreads) { // Protect iterator
            Iterator<JMeterThread> iter = new
HashSet<JMeterThread>(allThreads.keySet()).iterator();
            while (iter.hasNext()) {
                JMeterThread item = iter.next();
                item.stop(); // set stop flag
                item.interrupt(); // interrupt sampler if possible
                Thread t = allThreads.get(item);
                t.interrupt(); // also interrupt JVM thread           // <--
Line 542
            }
        }
    }

Regards,

Stephane

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 49734] Null pointer exception on stop Threads command (Run>Stop)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49734

--- Comment #2 from Cheng Chi <jo...@gmail.com> 2010-11-16 02:52:57 EST ---
(In reply to comment #1)
> Thanks for the report; fixed in SVN:
> 
> URL: http://svn.apache.org/viewvc?rev=986020&view=rev
> Log:
> Bug 49734 - Null pointer exception on stop Threads command (Run>Stop)
> 
> Modified:
>   
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java
>    jakarta/jmeter/trunk/xdocs/changes.xml

Hi, Sebb, 

The Fix is confused, can you explain why t can be 'null' here or shall we need
to dig the root cause deeper? :)

if (t != null ) { // Bug 49734
t.interrupt(); // also interrupt JVM thread
} 

Thanks!
Cheng Chi

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 49734] Null pointer exception on stop Threads command (Run>Stop)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49734

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Sebb <se...@apache.org> 2010-08-16 12:31:12 EDT ---
Thanks for the report; fixed in SVN:

URL: http://svn.apache.org/viewvc?rev=986020&view=rev
Log:
Bug 49734 - Null pointer exception on stop Threads command (Run>Stop)

Modified:
  
jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java
   jakarta/jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 49734] Null pointer exception on stop Threads command (Run>Stop)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49734

--- Comment #3 from Sebb <se...@apache.org> 2010-11-16 05:12:28 EST ---
See the original bug report stack trace.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org