You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/03 15:05:26 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7768: Issue 7767 - Short circuit remap reload when non-existent remap file is specified

SolidWallOfCode commented on a change in pull request #7768:
URL: https://github.com/apache/trafficserver/pull/7768#discussion_r625151738



##########
File path: proxy/http/remap/RemapConfig.cc
##########
@@ -949,7 +949,7 @@ remap_parse_config_bti(const char *path, BUILD_TABLE_INFO *bti)
     switch (ec.value()) {
     case ENOENT:
       Warning("Can't open remapping configuration file %s - %s", path, strerror(ec.value()));
-      break;
+      return true;

Review comment:
       Shouldn't that be `false`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org