You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/10/08 23:33:34 UTC
[jira] Created: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
-----------------------------------------------------------
Key: HBASE-1895
URL: https://issues.apache.org/jira/browse/HBASE-1895
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: ryan rawson
Fix For: 0.20.1, 0.21.0
the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
if (rlength > Short.MAX_VALUE) {
throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
}
so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1895:
---------------------------------
Fix Version/s: (was: 0.20.1)
0.20.2
0.20.1 is being released, bumping to 0.20.2
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.2, 0.21.0
>
> Attachments: HBASE-1895.patch
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "Amandeep Khurana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amandeep Khurana updated HBASE-1895:
------------------------------------
Attachment: HBASE-1895.patch
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.1, 0.21.0
>
> Attachments: HBASE-1895.patch
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1895:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to branch, somehow this was already fixed in trunk.
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.2, 0.21.0
>
> Attachments: HBASE-1895.patch
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "Amandeep Khurana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amandeep Khurana updated HBASE-1895:
------------------------------------
Assignee: Amandeep Khurana
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.1, 0.21.0
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764891#action_12764891 ]
ryan rawson commented on HBASE-1895:
------------------------------------
so far looking good, a test case would be great thanks!
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.2, 0.21.0
>
> Attachments: HBASE-1895.patch
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764217#action_12764217 ]
stack commented on HBASE-1895:
------------------------------
You want to make a patch ak?
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.1, 0.21.0
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1895) HConstants.MAX_ROW_LENGTH is
incorrectly 64k, should be 32k
Posted by "Amandeep Khurana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amandeep Khurana updated HBASE-1895:
------------------------------------
Status: Patch Available (was: Open)
Submitting patch. No test case yet.
> HConstants.MAX_ROW_LENGTH is incorrectly 64k, should be 32k
> -----------------------------------------------------------
>
> Key: HBASE-1895
> URL: https://issues.apache.org/jira/browse/HBASE-1895
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: ryan rawson
> Assignee: Amandeep Khurana
> Fix For: 0.20.1, 0.21.0
>
> Attachments: HBASE-1895.patch
>
>
> the max length of a row has to fit into a signed short. That is 32k. The constant is incorrect, but in the depths of KeyValue it does the right thing:
> if (rlength > Short.MAX_VALUE) {
> throw new IllegalArgumentException("Row > " + Short.MAX_VALUE);
> }
> so your Put wont fail and instead it will fail in the KeyValue constructor. So far only that 1 line in Put uses this constant, but we should have a correct value here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.