[GitHub] [calcite] hsyuan commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan
URL: https://github.com/apache/calcite/pull/1102#discussion_r264852382
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
 ##########
 @@ -1045,6 +1053,69 @@ public RelBuilder snapshot(RexNode period) {
     return this;
   }
 
+
+  /**
+   * Gets column mappings of the operator.
+   *
+   * @param op operator instance
+   * @return column mappings associated with this function
+   */
+  private Set<RelColumnMapping> getColumnMappings(SqlOperator op) {
+    SqlReturnTypeInference inference = op.getReturnTypeInference();
+    if (inference == null) {
+      return null;
+    }
 
 Review comment:
   L1065~1067  can be removed. If it is null, the instanceof will return false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services