You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/09 20:14:00 UTC
[jira] [Work logged] (GOBBLIN-1186) Fix SFDC
source.querybased.salesforce.is.soft.deletes.pull.disabled not available
for simple mode
[ https://issues.apache.org/jira/browse/GOBBLIN-1186?focusedWorklogId=443376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443376 ]
ASF GitHub Bot logged work on GOBBLIN-1186:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 20:13
Start Date: 09/Jun/20 20:13
Worklog Time Spent: 10m
Work Description: arekusuri opened a new pull request #3034:
URL: https://github.com/apache/incubator-gobblin/pull/3034
…etes.pull.disabled for simple mode
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1186
### Description
Problem statement
source.querybased.salesforce.is.soft.deletes.pull.disabled
doesn’t work for simple mode, it works only for dynamic mode.
the reason is - we explicitly set up the key-value for the dynamic mode
https://github.com/hanghangliu/gobblin/blob/9029a89b85ef373f78d603b14d6aaa75998f3356/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java#L327
Root cause
The extract state is blank(please see code)
What we set up in job file is not able to see in extractor state.
https://github.com/hashdoop/hashdoop-incubator-gobblin/blob/a871e5c5d6f539bcfbcc4e2850685c58dd72dd1a/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/QueryBasedSource.java#L234
Solution:
explicitly set up the soft.deletes.pull.disabled for simple mode, as we did for dynamic mode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 443376)
Remaining Estimate: 0h
Time Spent: 10m
> Fix SFDC source.querybased.salesforce.is.soft.deletes.pull.disabled not available for simple mode
> -------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1186
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1186
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Alex Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Problem statement*
> source.querybased.salesforce.is.soft.deletes.pull.disabled
> doesn’t work for simple mode, it works only for dynamic mode.
> the reason is - we explicitly set up the key-value for the dynamic mode
> [https://github.com/hanghangliu/gobblin/blob/9029a89b85ef373f78d603b14d6aaa75998f3356/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java#L327]
>
> *Root cause*
> The extract state is blank(please see code)
> What we set up in job file is not able to see in extractor state.
> [https://github.com/hashdoop/hashdoop-incubator-gobblin/blob/a871e5c5d6f539bcfbcc4e2850685c58dd72dd1a/gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/QueryBasedSource.java#L234]
>
> *Solution:*
> explicitly set up the {{soft.deletes.pull.disabled}} for simple mode, as we did for dynamic mode
--
This message was sent by Atlassian Jira
(v8.3.4#803005)