You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/12/01 09:27:50 UTC
[GitHub] incubator-hawq pull request #1031: HAWQ-1182. Add Macro for unused argument ...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/1031
HAWQ-1182. Add Macro for unused argument and variable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1031.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1031
----
commit a670199ba7d44802edc022f45baddf1850e6986f
Author: Paul Guo <pa...@gmail.com>
Date: 2016-12-01T09:01:03Z
HAWQ-1182. Add Macro for unused argument and variable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1031: HAWQ-1182. Add Macro for unused argument and var...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/1031
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1031: HAWQ-1182. Add Macro for unused argument ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1031#discussion_r90576041
--- Diff: src/include/postgres.h ---
@@ -513,6 +513,18 @@ extern void gp_set_thread_sigmasks(void);
extern void OnMoveOutCGroupForQE(void);
+#ifndef POSSIBLE_UNUSED_VAR
+#define POSSIBLE_UNUSED_VAR(x) ((void)x)
+#endif
+
+#ifndef POSSIBLE_UNUSED_ARG
+#define POSSIBLE_UNUSED_ARG(x) ((void)x)
+#endif
+
+#ifndef UNUSED_ARG
+#define UNUSED_ARG(x) ((void)x)
--- End diff --
It is because the tab stop shown on this page is 8, while that in hawq 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1031: HAWQ-1182. Add Macro for unused argument ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1031
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1031: HAWQ-1182. Add Macro for unused argument ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1031#discussion_r90413490
--- Diff: src/include/postgres.h ---
@@ -513,6 +513,18 @@ extern void gp_set_thread_sigmasks(void);
extern void OnMoveOutCGroupForQE(void);
+#ifndef POSSIBLE_UNUSED_VAR
+#define POSSIBLE_UNUSED_VAR(x) ((void)x)
+#endif
+
+#ifndef POSSIBLE_UNUSED_ARG
+#define POSSIBLE_UNUSED_ARG(x) ((void)x)
+#endif
+
+#ifndef UNUSED_ARG
+#define UNUSED_ARG(x) ((void)x)
--- End diff --
......indent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---