You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/09 10:23:02 UTC

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #999: MINIFICPP-1485 Improve 'exclusive property' error message (mini-PR)

fgerlits opened a new pull request #999:
URL: https://github.com/apache/nifi-minifi-cpp/pull/999


   https://issues.apache.org/jira/browse/MINIFICPP-1485
   
   Old error message:
   ```
   [error] Unable to parse configuration file for component named 'InvokeHTTP' because property
   'SSL Context Service' is exclusive of property 'Remote URL' values matching '^http:.*$'
   [in 'Processors' section of configuration file]
   ```
   New error message:
   ```
   [error] Unable to parse configuration file for component named 'InvokeHTTP' because property
   'SSL Context Service' must not be set when the value of property 'Remote URL' matches '^http:.*$'
   [in 'Processors' section of configuration file]
   ```
   
   ---
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #999: MINIFICPP-1485 Improve 'exclusive property' error message (mini-PR)

Posted by GitBox <gi...@apache.org>.

szaszm closed pull request #999:
URL: https://github.com/apache/nifi-minifi-cpp/pull/999


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #999: MINIFICPP-1485 Improve 'exclusive property' error message (mini-PR)

Posted by GitBox <gi...@apache.org>.

fgerlits commented on pull request #999:
URL: https://github.com/apache/nifi-minifi-cpp/pull/999#issuecomment-775939342


   > Looks good to me. However, I think readibility could be further improved with an error message like:
   > 
   > > The property "SSL Context Service" can only be used for "Remote URL" values that do not start with "http:".
   
   Yes, that would be better.  But our current `->withExclusiveProperty()` allows any regular expression, and parsing the regex to check whether it is of the form `^something.*$` would be overkill, I think.
   
   I would have done this the other way round, eg. `->withOtherPropertyMatchingRegex()` so we can say "property X must match regex ... if property Y is set" -- but changing this would break our yaml API, so I don't think we can do it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org