You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "HBase Review Board (JIRA)" <ji...@apache.org> on 2010/10/21 06:36:19 UTC
[jira] Commented: (HBASE-3102) Enhance HBase rMetrics for
Long-running Stats
[ https://issues.apache.org/jira/browse/HBASE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923316#action_12923316 ]
HBase Review Board commented on HBASE-3102:
-------------------------------------------
Message from: "Nicolas" <ns...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1055/
-----------------------------------------------------------
(Updated 2010-10-20 21:33:49.517352)
Review request for hbase.
Changes
-------
added flush metrics + fixed TestHeapSize for HRegion
Summary
-------
Example: a useful metric to observe track is compaction count + duration. Since compactions are long running and only happen infrequently, the avg/opcount stats are should be reset longer than the default polling period (5 sec). In addition to 'hbase.period', we should allow a different duration after which long-running metrics should expire. This would also fix our existing metrics problem where min/max stats are never reset until the process is restarted/upgraded.
This diff adds the capability for long-running metrics in addition to the infrastructure necessary to log compactions + log splits.
This addresses bug HBASE-3102.
http://issues.apache.org/jira/browse/HBASE-3102
Diffs (updated)
-----
trunk/conf/hadoop-metrics.properties 1025790
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/metrics/PersistentMetricsTimeVaryingRate.java PRE-CREATION
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java 1025790
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java 1025790
trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1025790
Diff: http://review.cloudera.org/r/1055/diff
Testing
-------
mvn clean install
cluster load test
** Note: this was primarily tested on 0.89. Minimal testing on 0.90
Thanks,
Nicolas
> Enhance HBase rMetrics for Long-running Stats
> ---------------------------------------------
>
> Key: HBASE-3102
> URL: https://issues.apache.org/jira/browse/HBASE-3102
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.90.0
>
> Attachments: HBASE-3102_90.patch
>
>
> Example: a useful metric to observe track is compaction count + duration. Since compactions are long running and only happen infrequently, the avg/opcount stats are should be reset longer than the default polling period (5 sec). In addition to 'hbase.period', we should allow a different duration after which long-running metrics should expire. This would also fix our existing metrics problem where min/max stats are never reset until the process is restarted/upgraded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.