You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2023/12/20 08:59:25 UTC
[PR] [feature](nereids)support decimalv2 [doris]
starocean999 opened a new pull request, #28726:
URL: https://github.com/apache/doris/pull/28726
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1864102111
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1866083060
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.79 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17183818245 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1865851627
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1866036664
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1865657996
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1866344417
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.73 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17183606729 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #28726:
URL: https://github.com/apache/doris/pull/28726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1866105167
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 41e08a857bfda40bfaad27839fa3ec6cf199ef11, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4693 4401 4418 4401
q2 362 153 158 153
q3 1440 1284 1208 1208
q4 1103 914 938 914
q5 3162 3124 3166 3124
q6 251 129 128 128
q7 1001 492 481 481
q8 2171 2214 2176 2176
q9 6703 6660 6643 6643
q10 3193 3240 3248 3240
q11 307 187 185 185
q12 344 214 211 211
q13 4539 3772 3816 3772
q14 242 216 212 212
q15 565 523 519 519
q16 440 386 387 386
q17 992 644 557 557
q18 7259 6901 6949 6901
q19 1502 1430 1359 1359
q20 502 316 298 298
q21 3039 2640 2638 2638
q22 344 276 282 276
Total cold run time: 44154 ms
Total hot run time: 39782 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4352 4315 4332 4315
q2 267 166 170 166
q3 3515 3512 3503 3503
q4 2362 2360 2367 2360
q5 5752 5711 5709 5709
q6 240 120 122 120
q7 2380 1877 1888 1877
q8 3499 3494 3499 3494
q9 8982 8984 8972 8972
q10 3922 3959 4013 3959
q11 488 377 361 361
q12 763 609 598 598
q13 4283 3580 3539 3539
q14 289 261 263 261
q15 562 516 525 516
q16 503 464 489 464
q17 1873 1854 1854 1854
q18 8613 8174 8252 8174
q19 1740 1739 1732 1732
q20 2241 1938 1924 1924
q21 6488 6148 6097 6097
q22 493 424 437 424
Total cold run time: 63607 ms
Total hot run time: 60419 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1864096872
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1864166184
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.3 seconds
stream load tsv: 565 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17183822678 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1865752031
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 7a3b6935e21d54ad4810a3e4d1ef9058ef60b659, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4706 4379 4398 4379
q2 366 148 158 148
q3 1457 1239 1238 1238
q4 1114 939 869 869
q5 3139 3146 3136 3136
q6 245 130 131 130
q7 996 487 482 482
q8 2170 2289 2185 2185
q9 6682 6708 6689 6689
q10 3215 3293 3266 3266
q11 311 186 182 182
q12 353 215 207 207
q13 4559 3784 3742 3742
q14 243 209 208 208
q15 569 521 520 520
q16 441 384 392 384
q17 994 578 569 569
q18 7204 6864 7024 6864
q19 1524 1401 1424 1401
q20 547 336 278 278
q21 3082 2670 2670 2670
q22 348 279 288 279
Total cold run time: 44265 ms
Total hot run time: 39826 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4358 4340 4336 4336
q2 269 162 170 162
q3 3521 3521 3523 3521
q4 2387 2372 2362 2362
q5 5746 5728 5727 5727
q6 248 126 127 126
q7 2367 1900 1867 1867
q8 3522 3541 3531 3531
q9 9011 8946 8932 8932
q10 3910 3986 3987 3986
q11 484 369 383 369
q12 765 602 594 594
q13 4272 3590 3556 3556
q14 281 254 258 254
q15 583 522 519 519
q16 504 441 466 441
q17 1884 1861 1867 1861
q18 8709 8246 8286 8246
q19 1734 1762 1771 1762
q20 2253 1959 1924 1924
q21 6547 6191 6172 6172
q22 509 439 435 435
Total cold run time: 63864 ms
Total hot run time: 60683 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1864102065
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1865747782
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.47 seconds
stream load tsv: 572 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17184013368 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1866153439
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1868679900
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1864185570
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit de4d19753969f3cd8b2b6e85d5c7f68af98a1098, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4709 4486 4538 4486
q2 371 143 158 143
q3 1484 1257 1259 1257
q4 1115 926 867 867
q5 3131 3161 3139 3139
q6 251 133 136 133
q7 987 496 491 491
q8 2223 2237 2168 2168
q9 6734 6686 6712 6686
q10 3231 3251 3278 3251
q11 310 186 196 186
q12 356 218 215 215
q13 4559 3810 3797 3797
q14 248 212 213 212
q15 563 518 540 518
q16 446 389 390 389
q17 1003 591 570 570
q18 7159 6959 6946 6946
q19 1528 1376 1452 1376
q20 539 306 311 306
q21 3101 2681 2717 2681
q22 351 278 287 278
Total cold run time: 44399 ms
Total hot run time: 40095 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4387 4389 4382 4382
q2 266 167 172 167
q3 3542 3549 3543 3543
q4 2400 2386 2391 2386
q5 5766 5760 5757 5757
q6 244 124 126 124
q7 2412 1860 1884 1860
q8 3517 3526 3527 3526
q9 9024 9026 9082 9026
q10 3934 4016 4022 4016
q11 493 379 375 375
q12 781 590 599 590
q13 4310 3588 3602 3588
q14 296 266 266 266
q15 568 523 520 520
q16 509 463 456 456
q17 1893 1861 1858 1858
q18 8564 8034 8282 8034
q19 1725 1781 1773 1773
q20 2255 1945 1942 1942
q21 6575 6230 6206 6206
q22 497 451 415 415
Total cold run time: 63958 ms
Total hot run time: 60810 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #28726:
URL: https://github.com/apache/doris/pull/28726#discussion_r1433720620
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##########
@@ -371,6 +373,7 @@ public static Expression subtractDoubleDouble(DoubleLiteral first, DoubleLiteral
@ExecFunction(name = "subtract", argTypes = {"DECIMAL", "DECIMAL"}, returnType = "DECIMAL")
public static Expression subtractDecimalDecimal(DecimalLiteral first, DecimalLiteral second) {
BigDecimal result = first.getValue().subtract(second.getValue());
+ DecimalV2Type.validateDecimalV2Type(result);
Review Comment:
check in DecimalLiteral directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids)support decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28726:
URL: https://github.com/apache/doris/pull/28726#issuecomment-1866345190
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 32cd0aa79720775ab6feb2c9af5887c0097ae008, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4693 4430 4418 4418
q2 359 168 156 156
q3 1460 1282 1200 1200
q4 1109 901 925 901
q5 3144 3143 3134 3134
q6 249 129 128 128
q7 1013 483 481 481
q8 2197 2220 2193 2193
q9 6699 6640 6690 6640
q10 3219 3248 3277 3248
q11 305 191 183 183
q12 350 213 205 205
q13 4524 3788 3766 3766
q14 240 227 217 217
q15 576 524 520 520
q16 445 382 385 382
q17 994 603 543 543
q18 7240 6913 6992 6913
q19 1513 1311 1430 1311
q20 513 309 299 299
q21 3076 2628 2654 2628
q22 346 281 291 281
Total cold run time: 44264 ms
Total hot run time: 39747 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4348 4339 4323 4323
q2 271 167 175 167
q3 3538 3533 3531 3531
q4 2378 2369 2358 2358
q5 5731 5707 5727 5707
q6 243 119 118 118
q7 2411 1859 1845 1845
q8 3514 3523 3515 3515
q9 9077 9037 9001 9001
q10 3916 3983 3982 3982
q11 487 376 356 356
q12 772 594 600 594
q13 4277 3572 3556 3556
q14 280 249 251 249
q15 563 523 528 523
q16 501 484 482 482
q17 1894 1876 1836 1836
q18 8689 8318 8276 8276
q19 1766 1760 1777 1760
q20 2247 1962 1930 1930
q21 6536 6158 6165 6158
q22 496 424 417 417
Total cold run time: 63935 ms
Total hot run time: 60684 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org