You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@apache.org> on 2016/06/14 22:03:58 UTC
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue
(DEBUG is cyan)
On 15 June 2016 at 05:25, <hb...@apache.org> wrote:
> Repository: maven
> Updated Branches:
> refs/heads/master ecdb0bc2b -> e7a783db1
>
>
> [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db
>
> Branch: refs/heads/master
> Commit: e7a783db1f577a340a91f6c958f1b9319c52c176
> Parents: ecdb0bc
> Author: Hervé Boutemy <hb...@apache.org>
> Authored: Tue Jun 14 21:25:02 2016 +0200
> Committer: Hervé Boutemy <hb...@apache.org>
> Committed: Tue Jun 14 21:25:02 2016 +0200
>
> ----------------------------------------------------------------------
> .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> ----------------------------------------------------------------------
> diff --git
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> index 00007cc..52e0489 100644
> ---
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> +++
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> @@ -50,7 +50,7 @@ extends com.planet57.gossip.render.PatternRenderer
> break;
>
> case INFO:
> - buff.append( ansi().bold().fgGreen().a( level.name()
> ).reset() );
> + buff.append( ansi().bold().fgBlue().a( level.name()
> ).reset() );
>
What about having color configurable? Ask few people they will all have
different opinions about the color to use.
So to avoid all of complains and jira issue asking color change etc...
having some configuration could IMHO ease our life :-) (french part you
know "les goûts et les couleurs" :-) )
Well not sure how as the current configuration file is included in the jar.
Furthermore I have no idea our externalise that.
> break;
>
> case WARN:
>
>
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue
(DEBUG is cyan)
Posted by Michael Osipov <mi...@apache.org>.
Am 2016-06-15 um 00:03 schrieb Olivier Lamy:
> On 15 June 2016 at 05:25, <hb...@apache.org> wrote:
>
>> Repository: maven
>> Updated Branches:
>> refs/heads/master ecdb0bc2b -> e7a783db1
>>
>>
>> [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
>>
>> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db
>> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db
>> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db
>>
>> Branch: refs/heads/master
>> Commit: e7a783db1f577a340a91f6c958f1b9319c52c176
>> Parents: ecdb0bc
>> Author: Hervé Boutemy <hb...@apache.org>
>> Authored: Tue Jun 14 21:25:02 2016 +0200
>> Committer: Hervé Boutemy <hb...@apache.org>
>> Committed: Tue Jun 14 21:25:02 2016 +0200
>>
>> ----------------------------------------------------------------------
>> .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
>> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
>> index 00007cc..52e0489 100644
>> ---
>> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
>> +++
>> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
>> @@ -50,7 +50,7 @@ extends com.planet57.gossip.render.PatternRenderer
>> break;
>>
>> case INFO:
>> - buff.append( ansi().bold().fgGreen().a( level.name()
>> ).reset() );
>> + buff.append( ansi().bold().fgBlue().a( level.name()
>> ).reset() );
>>
>
>
> What about having color configurable? Ask few people they will all have
> different opinions about the color to use.
> So to avoid all of complains and jira issue asking color change etc...
> having some configuration could IMHO ease our life :-) (french part you
> know "les goûts et les couleurs" :-) )
>
> Well not sure how as the current configuration file is included in the jar.
> Furthermore I have no idea our externalise that.
https://issues.apache.org/jira/browse/MNG-6044
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
Posted by Uwe Barthel <ba...@x-reizend.de>.
Hi,
> DEBUG/INFO/WARNING/ERROR schemes I'm thinking at:
> 1. bold cyan/bold green/bold yellow/bold red (initial)
> 2. bold cyan/bold blue/bold yellow/bold red (current)
> 3. cyan/blue/bold yellow/bold red (idea to have INFO less visible)
I prefer to use the standard console color (customised by user) for INFO instead of assign a fix color on that.
Most of the time the output is like I want and the bold yellow/red are eye-catcher.
Personally, I don't need a custom color for DEBUG.
If maven run in DEBUG mode almost 90% of the output is colored.
And if this color ist different to my own customized console color it's maybe unconfortable for me to read.
My suggestion:
DEBUG/INFO: leave as is, maybe make DEBUG bold but don’t change the color.
WARNING: bold yellow
ERROR: bold red
Regards,
-- barthel
> On 15 Jun 2016, at 08:19, Hervé BOUTEMY <he...@free.fr> wrote:
>
> Sorry guys, I did this while looking at a soccer match :) , not on my main
> computer, then without communicating...
>
> This one is a little bit like the Jenkins debate on the green vs blue bullet:
> this time, this was a remark on MNG-3507 that bold green on every INFO was too
> much... Then I found that bold Cyan DEBUG + bold Blue INFO was not a bad idea.
> But I have no strong opinion: this was a test, before we get too much habit
> with the initial implemented colors.
>
>
> On making colors configurable:
> - log level color configuration would be feasible, since only the logger has
> to implement it: but I don't expect much value, since it's only about
> DEBUG/INFO/WARNING/ERROR, then does it really deserve added complexity?
> - message level color configuration would be more complex, since this would
> require an API to be used by plugins: for this one, I strongly think we should
> at least wait a little bit before trying (and I'm not yet convinced this will
> be useful)
>
>
> Perhaps we should make tests on log level color and publish results to compare
> on the Wiki with screenshots. IMHO, for each configuration we'd need
> screenshots in misc configurations to check our main targets:
> - Linux vs Windows vs OSX
> - white background vs black background
> - success default vs success -X vs failure (perhaps prepare a reference build)
>
> DEBUG/INFO/WARNING/ERROR schemes I'm thinking at:
> 1. bold cyan/bold green/bold yellow/bold red (initial)
> 2. bold cyan/bold blue/bold yellow/bold red (current)
> 3. cyan/blue/bold yellow/bold red (idea to have INFO less visible)
>
> Ready to work with me on that?
> (and that could prepare some documentation on our color scheme)
>
> Regards,
>
> Hervé
>
> Le mercredi 15 juin 2016 08:03:58 Olivier Lamy a écrit :
>> On 15 June 2016 at 05:25, <hb...@apache.org> wrote:
>>> Repository: maven
>>>
>>> Updated Branches:
>>> refs/heads/master ecdb0bc2b -> e7a783db1
>>>
>>> [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db
>>> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db
>>> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db
>>>
>>> Branch: refs/heads/master
>>> Commit: e7a783db1f577a340a91f6c958f1b9319c52c176
>>> Parents: ecdb0bc
>>> Author: Hervé Boutemy <hb...@apache.org>
>>> Authored: Tue Jun 14 21:25:02 2016 +0200
>>> Committer: Hervé Boutemy <hb...@apache.org>
>>> Committed: Tue Jun 14 21:25:02 2016 +0200
>>>
>>> ----------------------------------------------------------------------
>>>
>>> .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> ----------------------------------------------------------------------
>>>
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/
>>> src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
>>> ----------------------------------------------------------------------
>>> diff --git
>>> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co
>>> lorRenderer.java
>>> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/C
>>> olorRenderer.java index 00007cc..52e0489 100644
>>> ---
>>> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co
>>> lorRenderer.java +++
>>> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co
>>> lorRenderer.java @@ -50,7 +50,7 @@ extends
>>> com.planet57.gossip.render.PatternRenderer>
>>> break;
>>>
>>> case INFO:
>>> - buff.append( ansi().bold().fgGreen().a( level.name()
>>> ).reset() );
>>> + buff.append( ansi().bold().fgBlue().a( level.name()
>>> ).reset() );
>>
>> What about having color configurable? Ask few people they will all have
>> different opinions about the color to use.
>> So to avoid all of complains and jira issue asking color change etc...
>> having some configuration could IMHO ease our life :-) (french part you
>> know "les goûts et les couleurs" :-) )
>>
>> Well not sure how as the current configuration file is included in the jar.
>> Furthermore I have no idea our externalise that.
>>
>>> break;
>>>
>>> case WARN:
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
Posted by Hervé BOUTEMY <he...@free.fr>.
Sorry guys, I did this while looking at a soccer match :) , not on my main
computer, then without communicating...
This one is a little bit like the Jenkins debate on the green vs blue bullet:
this time, this was a remark on MNG-3507 that bold green on every INFO was too
much... Then I found that bold Cyan DEBUG + bold Blue INFO was not a bad idea.
But I have no strong opinion: this was a test, before we get too much habit
with the initial implemented colors.
On making colors configurable:
- log level color configuration would be feasible, since only the logger has
to implement it: but I don't expect much value, since it's only about
DEBUG/INFO/WARNING/ERROR, then does it really deserve added complexity?
- message level color configuration would be more complex, since this would
require an API to be used by plugins: for this one, I strongly think we should
at least wait a little bit before trying (and I'm not yet convinced this will
be useful)
Perhaps we should make tests on log level color and publish results to compare
on the Wiki with screenshots. IMHO, for each configuration we'd need
screenshots in misc configurations to check our main targets:
- Linux vs Windows vs OSX
- white background vs black background
- success default vs success -X vs failure (perhaps prepare a reference build)
DEBUG/INFO/WARNING/ERROR schemes I'm thinking at:
1. bold cyan/bold green/bold yellow/bold red (initial)
2. bold cyan/bold blue/bold yellow/bold red (current)
3. cyan/blue/bold yellow/bold red (idea to have INFO less visible)
Ready to work with me on that?
(and that could prepare some documentation on our color scheme)
Regards,
Hervé
Le mercredi 15 juin 2016 08:03:58 Olivier Lamy a écrit :
> On 15 June 2016 at 05:25, <hb...@apache.org> wrote:
> > Repository: maven
> >
> > Updated Branches:
> > refs/heads/master ecdb0bc2b -> e7a783db1
> >
> > [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
> >
> > Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db
> > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db
> > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db
> >
> > Branch: refs/heads/master
> > Commit: e7a783db1f577a340a91f6c958f1b9319c52c176
> > Parents: ecdb0bc
> > Author: Hervé Boutemy <hb...@apache.org>
> > Authored: Tue Jun 14 21:25:02 2016 +0200
> > Committer: Hervé Boutemy <hb...@apache.org>
> > Committed: Tue Jun 14 21:25:02 2016 +0200
> >
> > ----------------------------------------------------------------------
> >
> > .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > ----------------------------------------------------------------------
> >
> >
> >
> > http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/
> > src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> > ----------------------------------------------------------------------
> > diff --git
> > a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co
> > lorRenderer.java
> > b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/C
> > olorRenderer.java index 00007cc..52e0489 100644
> > ---
> > a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co
> > lorRenderer.java +++
> > b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co
> > lorRenderer.java @@ -50,7 +50,7 @@ extends
> > com.planet57.gossip.render.PatternRenderer>
> > break;
> >
> > case INFO:
> > - buff.append( ansi().bold().fgGreen().a( level.name()
> > ).reset() );
> > + buff.append( ansi().bold().fgBlue().a( level.name()
> > ).reset() );
>
> What about having color configurable? Ask few people they will all have
> different opinions about the color to use.
> So to avoid all of complains and jira issue asking color change etc...
> having some configuration could IMHO ease our life :-) (french part you
> know "les goûts et les couleurs" :-) )
>
> Well not sure how as the current configuration file is included in the jar.
> Furthermore I have no idea our externalise that.
>
> > break;
> >
> > case WARN:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
Posted by Hervé BOUTEMY <he...@free.fr>.
I'm thinking at the API for one week now, and I think I found a simple idea:
let me 2 days (no time to work on it today) and we'll review
Regards,
Hervé
Le mercredi 15 juin 2016 17:37:08 Jason Dillon a écrit :
> > And if folks really just want any use of green to become blue, then yes
> > you can do that now and there is no reason to change anything further.
> > Though I kinda doubt that is what folks want when then think about
> > customization of colors. I expect folks really want more control over
> > “logger-level-info” is blue or green, similar to how IDEA or Eclipse can
> > let you configure colors based on context, and not simply doing color
> > replacements (i.e. everything green is now blue).
> >
> >
>
> Ok. Maybe we should not export jansi to plugin classpaths' then. We may
> need to provide a more sophisticated logging API supporting things like
> color and bold, italic, etc. If plugin developers start using jansi to
> provide ANSI escapes in log messages we cannot change anything to what
> they do later.
> I’d recommend the simple impl to see how the community takes to colors and
> gather feedback and ideas before doing anything more.
>
> I do think if folks are keen to the colors that perhaps a larger change to
> normalize how output is handled is probably in order, and that is why I
> didn’t try to go adding ansi directly to the plugin development api yet,
> but left it just in the logging system.
>
> I’m also not sure I’d want to expose ansi sequences directly to plugin
> development, but perhaps instead using an AnsiRenderer
> ( https://github.com/fusesource/jansi/blob/master/jansi/src/main/java/org/f
> usesource/jansi/AnsiRenderer.java ) style abstraction over the streams.
> Here I could imagine it fairly trivial to externalize the color attributes
> to a mapping model.
>
> I also don’t think that colors should be over-used, so exposing directly as
> api to all plugins could end up with pretty rainbow vomit on the console
> which could potentially negate the value of having colors to help signify
> bad or good things. Adding colors presently is a simple easy way at a
> glance to see these. But if it was up to each plugin to color as it felt,
> then the brain power needed to comprehend the output would grow
> exponentially, unless there was some abstraction over “good”, “bad”,
> “warning”, etc concepts.
>
> * * *
>
> In short, I would not recommend jumping directly into making ansi coloring
> of output part of the api proper and exposing to the community for
> extension at this time w/o further consideration and planning for how it
> would impact the platform generally.
>
> —jason
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: maven git commit: [MNG-3507] keep green for success: INFO
in blue (DEBUG is cyan)
Posted by Jason Dillon <ja...@planet57.com>.
> And if folks really just want any use of green to become blue, then yes
> you can do that now and there is no reason to change anything further.
> Though I kinda doubt that is what folks want when then think about
> customization of colors. I expect folks really want more control over
> “logger-level-info” is blue or green, similar to how IDEA or Eclipse can
> let you configure colors based on context, and not simply doing color
> replacements (i.e. everything green is now blue).
>
Ok. Maybe we should not export jansi to plugin classpaths' then. We may
need to provide a more sophisticated logging API supporting things like
color and bold, italic, etc. If plugin developers start using jansi to
provide ANSI escapes in log messages we cannot change anything to what
they do later.
I’d recommend the simple impl to see how the community takes to colors and gather feedback and ideas before doing anything more.
I do think if folks are keen to the colors that perhaps a larger change to normalize how output is handled is probably in order, and that is why I didn’t try to go adding ansi directly to the plugin development api yet, but left it just in the logging system.
I’m also not sure I’d want to expose ansi sequences directly to plugin development, but perhaps instead using an AnsiRenderer ( https://github.com/fusesource/jansi/blob/master/jansi/src/main/java/org/fusesource/jansi/AnsiRenderer.java ) style abstraction over the streams. Here I could imagine it fairly trivial to externalize the color attributes to a mapping model.
I also don’t think that colors should be over-used, so exposing directly as api to all plugins could end up with pretty rainbow vomit on the console which could potentially negate the value of having colors to help signify bad or good things. Adding colors presently is a simple easy way at a glance to see these. But if it was up to each plugin to color as it felt, then the brain power needed to comprehend the output would grow exponentially, unless there was some abstraction over “good”, “bad”, “warning”, etc concepts.
* * *
In short, I would not recommend jumping directly into making ansi coloring of output part of the api proper and exposing to the community for extension at this time w/o further consideration and planning for how it would impact the platform generally.
—jason
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue
(DEBUG is cyan)
Posted by Christian Schulte <cs...@schulte.it>.
Am 06/15/16 um 23:59 schrieb Jason Dillon:
> On June 15, 2016 at 12:07:32 AM, Christian Schulte (cs@schulte.it
> <ma...@schulte.it>) wrote:
>> Am 06/15/16 um 00:17 schrieb Jason Dillon:
>> > Making the colors configurable seems like a lot of overhead for what is otherwise fairly simple.
>> >
>> > I\u2019d recommend leaving the colors asis for now, get this out to let users actually make use of it, and then consider adding complexity later to make colors configurable.
>> >
>> > I don\u2019t see a clean way to make colors configurable w/o adding some sort of layer to make color names abstracted to symbols, which means adding additional logic to resolve the color symbol name to real color, and likely a completely different api to render text with these abstract names.
>> >
>>
>> Isn't this the job of the terminal in use? It can map the ANSI colors to
>> something different already, I think.
>
> That would only work to change all instances of a standard ANSI color to
> another. Not to customize what the colors of various bits are. For
> example if you like [INFO] as green, but someone else likes [INFO] as
> blue
> ( https://github.com/apache/maven/commit/e7a783db1f577a340a91f6c958f1b9319c52c176 ).
> Using the terminal here could only change any use of fgGreen to
> whatever color you preferred, not just specifically the [INFO] segment.
>
> And if folks really just want any use of green to become blue, then yes
> you can do that now and there is no reason to change anything further.
> Though I kinda doubt that is what folks want when then think about
> customization of colors. I expect folks really want more control over
> \u201clogger-level-info\u201d is blue or green, similar to how IDEA or Eclipse can
> let you configure colors based on context, and not simply doing color
> replacements (i.e. everything green is now blue).
>
Ok. Maybe we should not export jansi to plugin classpaths' then. We may
need to provide a more sophisticated logging API supporting things like
color and bold, italic, etc. If plugin developers start using jansi to
provide ANSI escapes in log messages we cannot change anything to what
they do later.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: maven git commit: [MNG-3507] keep green for success: INFO
in blue (DEBUG is cyan)
Posted by Jason Dillon <ja...@planet57.com>.
On June 15, 2016 at 12:07:32 AM, Christian Schulte (cs@schulte.it) wrote:
Am 06/15/16 um 00:17 schrieb Jason Dillon:
> Making the colors configurable seems like a lot of overhead for what is otherwise fairly simple.
>
> I’d recommend leaving the colors asis for now, get this out to let users actually make use of it, and then consider adding complexity later to make colors configurable.
>
> I don’t see a clean way to make colors configurable w/o adding some sort of layer to make color names abstracted to symbols, which means adding additional logic to resolve the color symbol name to real color, and likely a completely different api to render text with these abstract names.
>
Isn't this the job of the terminal in use? It can map the ANSI colors to
something different already, I think.
That would only work to change all instances of a standard ANSI color to another. Not to customize what the colors of various bits are. For example if you like [INFO] as green, but someone else likes [INFO] as blue ( https://github.com/apache/maven/commit/e7a783db1f577a340a91f6c958f1b9319c52c176 ). Using the terminal here could only change any use of fgGreen to whatever color you preferred, not just specifically the [INFO] segment.
And if folks really just want any use of green to become blue, then yes you can do that now and there is no reason to change anything further. Though I kinda doubt that is what folks want when then think about customization of colors. I expect folks really want more control over “logger-level-info” is blue or green, similar to how IDEA or Eclipse can let you configure colors based on context, and not simply doing color replacements (i.e. everything green is now blue).
—jason
Re: maven git commit: [MNG-3507] keep green for success: INFO in blue
(DEBUG is cyan)
Posted by Christian Schulte <cs...@schulte.it>.
Am 06/15/16 um 00:17 schrieb Jason Dillon:
> Making the colors configurable seems like a lot of overhead for what is otherwise fairly simple.
>
> I\u2019d recommend leaving the colors asis for now, get this out to let users actually make use of it, and then consider adding complexity later to make colors configurable.
>
> I don\u2019t see a clean way to make colors configurable w/o adding some sort of layer to make color names abstracted to symbols, which means adding additional logic to resolve the color symbol name to real color, and likely a completely different api to render text with these abstract names.
>
Isn't this the job of the terminal in use? It can map the ANSI colors to
something different already, I think.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: maven git commit: [MNG-3507] keep green for success: INFO
in blue (DEBUG is cyan)
Posted by Jason Dillon <ja...@planet57.com>.
Making the colors configurable seems like a lot of overhead for what is otherwise fairly simple.
I’d recommend leaving the colors asis for now, get this out to let users actually make use of it, and then consider adding complexity later to make colors configurable.
I don’t see a clean way to make colors configurable w/o adding some sort of layer to make color names abstracted to symbols, which means adding additional logic to resolve the color symbol name to real color, and likely a completely different api to render text with these abstract names.
This is IMO overkill for a first release of mvn + ansi color support.
—jason
On June 14, 2016 at 3:04:20 PM, Olivier Lamy (olamy@apache.org) wrote:
On 15 June 2016 at 05:25, <hb...@apache.org> wrote:
> Repository: maven
> Updated Branches:
> refs/heads/master ecdb0bc2b -> e7a783db1
>
>
> [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db
>
> Branch: refs/heads/master
> Commit: e7a783db1f577a340a91f6c958f1b9319c52c176
> Parents: ecdb0bc
> Author: Hervé Boutemy <hb...@apache.org>
> Authored: Tue Jun 14 21:25:02 2016 +0200
> Committer: Hervé Boutemy <hb...@apache.org>
> Committed: Tue Jun 14 21:25:02 2016 +0200
>
> ----------------------------------------------------------------------
> .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> ----------------------------------------------------------------------
> diff --git
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> index 00007cc..52e0489 100644
> ---
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> +++
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> @@ -50,7 +50,7 @@ extends com.planet57.gossip.render.PatternRenderer
> break;
>
> case INFO:
> - buff.append( ansi().bold().fgGreen().a( level.name()
> ).reset() );
> + buff.append( ansi().bold().fgBlue().a( level.name()
> ).reset() );
>
What about having color configurable? Ask few people they will all have
different opinions about the color to use.
So to avoid all of complains and jira issue asking color change etc...
having some configuration could IMHO ease our life :-) (french part you
know "les goûts et les couleurs" :-) )
Well not sure how as the current configuration file is included in the jar.
Furthermore I have no idea our externalise that.
> break;
>
> case WARN:
>
>