[GitHub] [unomi] jkevan commented on a change in pull request #287: DMF-4406 : handle parameters validation

[GitBox <gi...@apache.org>]

jkevan commented on a change in pull request #287:
URL: https://github.com/apache/unomi/pull/287#discussion_r611758395



##########
File path: rest/src/main/java/org/apache/unomi/rest/EventsCollectorEndpoint.java
##########
@@ -75,13 +76,15 @@ public Response options() {
 
     @GET
     @Path("/eventcollector")
-    public EventCollectorResponse collectAsGet(EventsCollectorRequest eventsCollectorRequest, @QueryParam("timestamp") Long timestampAsString) {
+    public EventCollectorResponse collectAsGet(@NotNull EventsCollectorRequest eventsCollectorRequest,
+            @QueryParam("timestamp") Long timestampAsString) {
         return doEvent(eventsCollectorRequest, timestampAsString);
     }
 
     @POST
     @Path("/eventcollector")
-    public EventCollectorResponse collectAsPost(EventsCollectorRequest eventsCollectorRequest, @QueryParam("timestamp") Long timestampAsLong) {
+    public EventCollectorResponse collectAsPost(EventsCollectorRequest eventsCollectorRequest,

Review comment:
       Should be annotate also with NotNull for Post

##########
File path: rest/src/main/java/org/apache/unomi/rest/validation/JAXRSBeanValidationInInterceptorOverride.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.unomi.rest.validation;
+
+import org.apache.cxf.jaxrs.validation.JAXRSBeanValidationInInterceptor;
+import org.apache.cxf.message.Message;
+
+import java.lang.reflect.Method;
+import java.util.List;
+
+/**
+ * This class allows to replace the class loader use by
+ * javax.el.FactoryFinder.newInstance(FactoryFinder.java:53)
+ * to allow to retrieve com.sun.el.ExpressionFactoryImpl which is present in the class loader of this module
+ */
+public class JAXRSBeanValidationInInterceptorOverride extends JAXRSBeanValidationInInterceptor {

Review comment:
       It's not used :D
   We should use it in the RestServer instead of the JAXRSBeanValidationInInterceptor




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org