You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/05 00:30:32 UTC

Re: Review Request 15016: Added local timeout to Group.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15016/#review28151
-----------------------------------------------------------


Any chance you can split apart the move of GroupProcess and the addition of the timer into separate reviews?

- Ben Mahler


On Oct. 30, 2013, 5:13 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15016/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 5:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> - Moved GroupProcess declaration to hpp because it is used in tests. (In https://reviews.apache.org/r/13087/)
> - Added local timeout so that Group operations fail after we locally determine that the session is timed out.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/group.hpp 6b6c1557658df1bb7b7df3ded5c203e2dc0c8308 
>   src/zookeeper/group.cpp cd58d230a2715b9ed01002443ebd7b5366d31be6 
> 
> Diff: https://reviews.apache.org/r/15016/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>