You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by xguo27 <gi...@git.apache.org> on 2015/11/11 02:14:37 UTC
[GitHub] spark pull request: [SPARK-11628][SQL][WIP] support column datatyp...
GitHub user xguo27 opened a pull request:
https://github.com/apache/spark/pull/9612
[SPARK-11628][SQL][WIP] support column datatype of Char
Can someone review my code to make sure I'm not missing anything? Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xguo27/spark SPARK-11628
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9612
----
commit 12a7ba151291691d1695fc456da65fb3c005fc2d
Author: Xiu Guo <gu...@us.ibm.com>
Date: 2015-11-11T00:44:22Z
[SPARK-11628][SQL] support column datatype of Char
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11628][SQL][WIP] support column datatyp...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9612#issuecomment-155622425
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11628][SQL][WIP] support column datatyp...
Posted by xguo27 <gi...@git.apache.org>.
Github user xguo27 commented on the pull request:
https://github.com/apache/spark/pull/9612#issuecomment-156276620
Hi Wenchen:
Can you elaborate on using ByteType for char a little more?
Ultimately, the difference between char(x) and varchar(x) is the fixed/variable length, which results in padding. So it's a good idea to keep the underlying type the same, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11628][SQL][WIP] support column datatyp...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9612#issuecomment-155656684
Can't we use `ByteType` for char column?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11628][SQL][WIP] support column datatyp...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9612#issuecomment-156295206
Ah, sorry for the misunderstanding, I though you mean the one-byte `Char` in programing language...
Can you update your PR title to say that you are fixing hive part to recognize `HiveChar`? And please also add more tests to make sure we can read and write hive table with char(x) type columns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11628][SQL][WIP] support column datatyp...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9612#discussion_r44505240
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala ---
@@ -96,6 +96,7 @@ private[sql] object JDBCRDD extends Logging {
case java.sql.Types.TINYINT => IntegerType
case java.sql.Types.VARBINARY => BinaryType
case java.sql.Types.VARCHAR => StringType
+ case java.sql.Types.CHAR => StringType
--- End diff --
case java.sql.Types.CHAR => StringType
Repeat code between line99 and line 65, plz delete this code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org