You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by rerngvit <gi...@git.apache.org> on 2016/07/20 23:08:00 UTC
[GitHub] zeppelin pull request #1211: [ZEPPELIN-910] New interpreter registration mec...
GitHub user rerngvit opened a pull request:
https://github.com/apache/zeppelin/pull/1211
[ZEPPELIN-910] New interpreter registration mechanism to HDFSFileInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to HDFSFileInterpreter
### What type of PR is it?
Improvement
### Todos
Move interpreter registration properties from a static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-910
### How should this be tested?
1. apply patch
2. rm conf/interpreter.json
3. mvn clean package -DskipTests
4. bin/zeppelin-daemon.sh start
5. Configure %file interpreter setting according to your HDFS setup
6. run some paragraph with HDFS file access
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerngvit/incubator-zeppelin ZEPPELIN-804
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1211
----
commit b1ebf67b66de1d4c7609da8acbd5ce159f2fee3a
Author: Rerngvit Yanggratoke <re...@gmail.com>
Date: 2016-07-20T21:29:06Z
This PR applies the new interpreter registration mechanism to HDFSFileInterpreter
Improvement
- Move interpreter registration properties from static block to interpreter-setting.json
https://issues.apache.org/jira/browse/ZEPPELIN-910
1. apply patch
2. rm conf/interpreter.json
3. mvn clean package -DskipTests
4. bin/zeppelin-daemon.sh start
5. Configure %file interpreter setting according to your HDFS setup
6. run some paragraph with HDFS file access
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1211
@rerngvit thank you for contributing! Please check if I have correctly assigned JIRA id for this issue to keep attribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1211
Looks good to me.
CI failure is due to flaky R test and is treked under [ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862)
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1211
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...
Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:
https://github.com/apache/zeppelin/pull/1211
@jongyoul Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1211
I've checked if the tests of FileInterpreter have passed. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1211: [ZEPPELIN-910] New interpreter registration mechanism ...
Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:
https://github.com/apache/zeppelin/pull/1211
@bzz No problem. The JIRA id is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1211: [ZEPPELIN-910] New interpreter registration mec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---