[GitHub] sijie commented on a change in pull request #1160: Dump config

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1160: Dump config
URL: https://github.com/apache/bookkeeper/pull/1160#discussion_r168899336
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
 ##########
 @@ -618,4 +618,22 @@ public String getTLSEnabledProtocols() {
      * Trickery to allow inheritance with fluent style.
      */
     protected abstract T getThis();
+
+    /**
+     * converts the config into string format, by appending the config values
+     * and separated by 'separator'.
+     *
+     * @param separator
+     *            separator to separate the configs in string
+     */
+    public String configAsString(String separator) {
 
 Review comment:
   http configuration service is also dumping config. can we reuse (or consolidate) the logic of these two places. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services