You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "kashvi0 (via GitHub)" <gi...@apache.org> on 2024/04/09 17:07:27 UTC
[PR] Issue #3763 - Removed unused value of consumerGroup [eventmesh-go]
kashvi0 opened a new pull request, #20:
URL: https://github.com/apache/eventmesh-go/pull/20
I removed the unused value. The import statements moved when I saved the file. (Didn't make any difference)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] Issue #3763 - Removed unused value of consumerGroup [eventmesh-go]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #20:
URL: https://github.com/apache/eventmesh-go/pull/20#issuecomment-2046333648
The change looks fine. Please check CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [Issue #3763] This value of consumerGroup is never used [eventmesh-go]
Posted by "kashvi0 (via GitHub)" <gi...@apache.org>.
kashvi0 commented on PR #20:
URL: https://github.com/apache/eventmesh-go/pull/20#issuecomment-2048037666
does this look fine now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Merge pull request #20 from kashvi0/fix-issue - Fixes Issue #3763 [eventmesh-go]
Posted by "kashvi0 (via GitHub)" <gi...@apache.org>.
kashvi0 commented on PR #20:
URL: https://github.com/apache/eventmesh-go/pull/20#issuecomment-2046646014
Made the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Merge pull request #20 from kashvi0/fix-issue - Fixes Issue #3763 [eventmesh-go]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #20:
URL: https://github.com/apache/eventmesh-go/pull/20#issuecomment-2046826233
No, you need to link to the issue.
Standard title format: https://github.com/apache/eventmesh/pulls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Issue #3763 - Removed unused value of consumerGroup [eventmesh-go]
Posted by "kashvi0 (via GitHub)" <gi...@apache.org>.
kashvi0 commented on PR #20:
URL: https://github.com/apache/eventmesh-go/pull/20#issuecomment-2046538800
the errors i'm getting are:
1. "Error: could not import github.com/.../.../..." - all of these errors are there because of "page not found". The repo might have been updated.
2. "Error: Error return value of `...` is not checked (errcheck)" - error handling is required.
3. "Error: func `...` is unused (unused)" - i can remove the unused functions or these errors can be ignored for now.
4. "Error: SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)" - we can use a key type
please let me know if i should make any further changes to the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Issue #3763 - Removed unused value of consumerGroup [eventmesh-go]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #20:
URL: https://github.com/apache/eventmesh-go/pull/20#issuecomment-2046626127
It looks like the ci error is an ongoing problem, so let's ignore it.
Kindly refer to the standard title format used in other PRs of EventMesh and add 'Fixes' keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org