You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/06/02 03:50:38 UTC

[GitHub] [struts-archetypes] allc opened a new pull request #7: Fix class name in struts.xml for archetype starter

allc opened a new pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7


   Fix class name in `struts.xml` for archetype starter


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts-archetypes] lukaszlenart commented on a change in pull request #7: Fix class name in struts.xml for archetype starter

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7#discussion_r433643296



##########
File path: struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/struts.xml
##########
@@ -16,7 +16,7 @@
             <result>/WEB-INF/jsp/index.jsp</result>
         </action>
 
-        <action name="helloWorld" class="helloWorldAction">
+        <action name="helloWorld" class="${package}.HelloWorldAction">

Review comment:
       This need to match Spring bean name [here](https://github.com/apache/struts-archetypes/blob/master/struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/applicationContext.xml#L6), btw. the package name need to be fixed there




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts-archetypes] lukaszlenart closed pull request #7: Fix class name in struts.xml for archetype starter

Posted by GitBox <gi...@apache.org>.
lukaszlenart closed pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts-archetypes] lukaszlenart commented on a change in pull request #7: Fix class name in struts.xml for archetype starter

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7#discussion_r434359012



##########
File path: struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/struts.xml
##########
@@ -16,7 +16,7 @@
             <result>/WEB-INF/jsp/index.jsp</result>
         </action>
 
-        <action name="helloWorld" class="helloWorldAction">
+        <action name="helloWorld" class="${package}.HelloWorldAction">

Review comment:
       Thanks! We fixed a lot of problems and now the archetypes are under test phase, then we release new versions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts-archetypes] allc commented on a change in pull request #7: Fix class name in struts.xml for archetype starter

Posted by GitBox <gi...@apache.org>.
allc commented on a change in pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7#discussion_r434354664



##########
File path: struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/struts.xml
##########
@@ -16,7 +16,7 @@
             <result>/WEB-INF/jsp/index.jsp</result>
         </action>
 
-        <action name="helloWorld" class="helloWorldAction">
+        <action name="helloWorld" class="${package}.HelloWorldAction">

Review comment:
       Thanks for the review. Sorry I did not realise the `helloWorld` action here looks intentionally different from the `index` action as there is Spring bean for it.
   
   When I setup the project with this archetype from the repositories somehow some files did not generate including `applicationContext.xml`, and have caused this confusion. Now I have tried installing this version here on git again and it works fine. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org