You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/06/25 20:47:42 UTC

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3497

to review the following change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................

locks: change kudu::shared_lock constructor to pass by ref

This is less Kudu-style friendly, but it'll make the (eventual) transition
to the C++14 std::shared_lock smoother, and it's also more consistent with
std::lock_guard.

Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
---
M src/kudu/client/meta_cache.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpcz_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/util/locks.h
9 files changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/3497/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


locks: change kudu::shared_lock constructor to pass by ref

This is less Kudu-style friendly, but it'll make the (eventual) transition
to the C++14 std::shared_lock smoother, and it's also more consistent with
std::lock_guard.

Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Reviewed-on: http://gerrit.cloudera.org:8080/3497
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Dan Burkert <da...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/meta_cache.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpcz_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/util/locks.h
9 files changed, 20 insertions(+), 20 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Adar Dembo: Verified
  Todd Lipcon: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2067/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 5: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2076/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3497/2/src/kudu/util/locks.h
File src/kudu/util/locks.h:

Line 242:     : m_(DCHECK_NOTNULL(&m)) {
> this DCHECK seems a bit silly now (if we tried to create a null reference t
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2056/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2062/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3497

to look at the new patch set (#3).

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................

locks: change kudu::shared_lock constructor to pass by ref

This is less Kudu-style friendly, but it'll make the (eventual) transition
to the C++14 std::shared_lock smoother, and it's also more consistent with
std::lock_guard.

Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
---
M src/kudu/client/meta_cache.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpcz_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/util/locks.h
9 files changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/3497/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3497/2/src/kudu/util/locks.h
File src/kudu/util/locks.h:

Line 242:     : m_(DCHECK_NOTNULL(&m)) {
this DCHECK seems a bit silly now (if we tried to create a null reference then the UBSAN builds would flag it already)


-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1995/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 2: Code-Review+1

LGTM except for Todd's comment

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1991/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No