You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "ShadowySpirits (via GitHub)" <gi...@apache.org> on 2023/04/26 12:23:41 UTC
[GitHub] [incubator-opendal] ShadowySpirits opened a new pull request, #2135: fix(clippy): suppress dead_code check
ShadowySpirits opened a new pull request, #2135:
URL: https://github.com/apache/incubator-opendal/pull/2135
fix #2134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] ShadowySpirits commented on a diff in pull request #2135: fix(clippy): suppress dead_code check
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #2135:
URL: https://github.com/apache/incubator-opendal/pull/2135#discussion_r1177805239
##########
bindings/java/src/lib.rs:
##########
@@ -42,6 +42,7 @@ thread_local! {
static JENV: RefCell<Option<*mut jni::sys::JNIEnv>> = RefCell::new(None);
}
+#[allow(dead_code)]
Review Comment:
This method is probably to be used later, how about we keep it until the development of java-binding is completed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2135: fix(clippy): suppress dead_code check
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2135:
URL: https://github.com/apache/incubator-opendal/pull/2135#discussion_r1177799110
##########
bindings/java/src/lib.rs:
##########
@@ -42,6 +42,7 @@ thread_local! {
static JENV: RefCell<Option<*mut jni::sys::JNIEnv>> = RefCell::new(None);
}
+#[allow(dead_code)]
Review Comment:
Please remove this function directly since we are not using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2135: fix(clippy): suppress dead_code check
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2135:
URL: https://github.com/apache/incubator-opendal/pull/2135#discussion_r1177829690
##########
bindings/java/src/lib.rs:
##########
@@ -42,6 +42,7 @@ thread_local! {
static JENV: RefCell<Option<*mut jni::sys::JNIEnv>> = RefCell::new(None);
}
+#[allow(dead_code)]
Review Comment:
No, I prefer adding it while really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2135: fix(clippy): suppress dead_code check
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2135:
URL: https://github.com/apache/incubator-opendal/pull/2135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org