You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/08 14:46:48 UTC
[GitHub] [camel] squakez opened a new pull request #5315: feat(core): hasErrorHandlerBuilder helper method
squakez opened a new pull request #5315:
URL: https://github.com/apache/camel/pull/5315
Adding this method allows to check if any errorHandlerBuilder exists, before to be initialized by the getErrorHandlerBuilder method (which set a default one if it does not exists).
We are implementing a mechanism to [enable error handling in KameletBinding](https://github.com/apache/camel-k/issues/1941) and we need to check if any exists in the BuilderSupport prior to its default setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] squakez commented on a change in pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #5315:
URL: https://github.com/apache/camel/pull/5315#discussion_r609791613
##########
File path: core/camel-core-model/src/main/java/org/apache/camel/builder/BuilderSupport.java
##########
@@ -453,6 +453,10 @@ public void setContext(CamelContext context) {
this.context = context;
}
+ public boolean hasErrorHandlerBuilder(){
Review comment:
Yep, did not notice that, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5315:
URL: https://github.com/apache/camel/pull/5315#issuecomment-817257944
There is no branch for 3.9 - its a non LTS release so there will not be any patches of it. Only LTS releases have patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #5315:
URL: https://github.com/apache/camel/pull/5315#issuecomment-816646218
It is an api change so I don't think we can backport it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] squakez commented on pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #5315:
URL: https://github.com/apache/camel/pull/5315#issuecomment-815884766
cc @lburgazzoli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5315:
URL: https://github.com/apache/camel/pull/5315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] squakez commented on pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #5315:
URL: https://github.com/apache/camel/pull/5315#issuecomment-816645488
@lburgazzoli should I backport to 3.9 in order to be picked by the runtime? or do we plan to move to 3.10 shortly by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on a change in pull request #5315: feat(core): hasErrorHandlerBuilder helper method
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #5315:
URL: https://github.com/apache/camel/pull/5315#discussion_r609787965
##########
File path: core/camel-core-model/src/main/java/org/apache/camel/builder/BuilderSupport.java
##########
@@ -453,6 +453,10 @@ public void setContext(CamelContext context) {
this.context = context;
}
+ public boolean hasErrorHandlerBuilder(){
Review comment:
there may be a checkstyle issue here (no space before bracket)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org