[GitHub] [helix] micahstubbs commented on a diff in pull request #2129: Upgrade helix-front to Angular 10.2

[GitBox <gi...@apache.org>]

micahstubbs commented on code in PR #2129:
URL: https://github.com/apache/helix/pull/2129#discussion_r888385277


##########
helix-front/package.json:
##########
@@ -67,8 +68,8 @@
     "rxjs": "^6.5.5",
     "rxjs-compat": "^6.0.0-rc.0",
     "sass": "^1.51.0",
-    "tsickle": "^0.38.1",
-    "tslib": "^1.10.0",
+    "tsickle": "github:angular/tsickle#fdf6e86717648f1b9603752cb83486fa6dcac38f",

Review Comment:
   This is necessary because tsickle did not publish a release which supports `"typescript": "4.0.8"` which we need for other packages.
   
   Details in this Github issue comment: https://github.com/apache/helix/issues/2095#issuecomment-1128148592



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org