You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/05/19 13:05:30 UTC

[GitHub] [accumulo] milleruntime commented on a change in pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets

milleruntime commented on a change in pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560#discussion_r427285465



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -549,7 +549,9 @@
   TSERV_SLOW_FILEPERMIT_MILLIS("tserver.slow.filepermit.time", "100ms", PropertyType.TIMEDURATION,
       "If a thread blocks more than this period of time waiting to get file permits,"
           + " debugging information will be written."),
-
+  TSERV_BULK_MAX_TABLET_OVERLAP("tserver.bulk.max.overlap", "0", PropertyType.COUNT,

Review comment:
       I agree, I don't think users care whether the prefix is tserver or master.  I don't think its worth going through a deprecation cycle to migrate all of the ```tserver``` properties to ```master``` or ```general```.  That just adds extra unnecessary work for users.  I think the name ```master.bulk.max.tablets``` is OK.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org