[whimsy] 02/02: use parse agenda to identify missing reports

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git

commit 38036444bff1ba05772641fc3ff126862fee4a72
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Mon May 21 21:44:53 2018 -0400

    use parse agenda to identify missing reports
---
 www/board/agenda/views/committers_report.text.rb | 33 +++++++-----------------
 1 file changed, 9 insertions(+), 24 deletions(-)

diff --git a/www/board/agenda/views/committers_report.text.rb b/www/board/agenda/views/committers_report.text.rb
index b94ef38..a75024b 100644
--- a/www/board/agenda/views/committers_report.text.rb
+++ b/www/board/agenda/views/committers_report.text.rb
@@ -40,6 +40,15 @@ end
 attendance = attendance.group_by {|name, info| info[:role]}.
   map {|group, list| [group, list.map {|name, info| name}]}.to_h
 
+# get a list of missing attachments
+missing_reports = Array.new
+agenda.each do |item|
+  next unless item['missing']
+  next if item['to'] == 'president'
+  missing_reports << "Report from the Apache #{item['title']} Project" +
+    "  [#{item['owner']}]"
+end
+
 ##### Parse the agenda to find the data items above
 
 # Data items from agenda
@@ -50,7 +59,6 @@ month           = nil
 year            = nil
 minutes         = Array.new
 resolutions     = Array.new
-missing_reports = Array.new
 
 # State variables
 parsing_resolutions = false
@@ -91,29 +99,6 @@ File.open(agenda_file).each do |line|
     end
   end
 
-  # 6: Get the list of missing reports (aka empty attachments)
-  if !parsing_attachment && line =~ /^Attachment (..?): (.*)/
-    parsing_attachment = $1
-    current_attachment = $2
-    next
-  end
-  if parsing_attachment
-    if line.strip == ""
-      next
-    end
-    if line.strip == "-----------------------------------------"
-      if parsing_attachment.to_i.between?(1, 6)
-        puts "Skipping missing President Committee attachment: #{current_attachment}"
-      else
-        missing_reports << current_attachment
-      end
-      parsing_attachment = nil
-      next
-    end
-    parsing_attachment = nil
-    next
-  end
-
 end
 
 ##### 7: Find out the date of the next board report

-- 
To stop receiving notification emails like this one, please contact
rubys@apache.org.