[GitHub] [james-project] jeantil commented on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder

[GitBox <gi...@apache.org>]

jeantil commented on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-859081682


   I did a superficial review since the PR is huge and PRs consisting mainly of file moves are hard to read :) 
   ( I am currenty in the eye of the cyclone the package has arrived but won't reach home before saturday)
   The new organization looks fine to me. 
   The only thing that got me surprised was the choice to split 
   - cassandra-app-ldap-tests
   - cli-integration-tests
   - distributed-ldap-tests
   Away from their respective modules (if I understand this change correctly). It puts testing modules in the apps/assembly directory which I find counter intuitive even if they are clearly marked as being tests.
   
   Can you explain the rationale behind the split ? I'm not opposed but I would like to understand the why as it breaks expectations, and maybe ask that the why be explained in a readme in the apps dir so that people proposing new assemblies or manipulating assemblies would know if they need to provide a test module too. 
   Appart from that I'm all for it once the CI clears


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org