You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/18 00:42:23 UTC
[kudu-CR] [mini-cluster] fix build if NO TESTS=1
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19761
Change subject: [mini-cluster] fix build if NO_TESTS=1
......................................................................
[mini-cluster] fix build if NO_TESTS=1
Prior to this patch, the build would fail if building with NO_TESTS=1:
DEBUG:
Linking CXX shared library ../../../lib/libmini_cluster.so
ld.gold: error: cannot find -lsecurity_test_util
collect2: error: ld returned 1 exit status
RELEASE:
Linking CXX executable ../../../bin/kudu
ld.gold: error: cannot find -lsecurity_test_util
collect2: error: ld returned 1 exit status
This is a follow-up to 8595384de007963181cca59b0248b85169f18792.
Change-Id: Ie5bd16c049cb4494856ae872554e79ab0bd4785f
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/19761/1
--
To view, visit http://gerrit.cloudera.org:8080/19761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5bd16c049cb4494856ae872554e79ab0bd4785f
Gerrit-Change-Number: 19761
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [mini-cluster] fix build if NO TESTS=1
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19761 )
Change subject: [mini-cluster] fix build if NO_TESTS=1
......................................................................
[mini-cluster] fix build if NO_TESTS=1
Prior to this patch, the build would fail if building with NO_TESTS=1:
DEBUG:
Linking CXX shared library ../../../lib/libmini_cluster.so
ld.gold: error: cannot find -lsecurity_test_util
collect2: error: ld returned 1 exit status
RELEASE:
Linking CXX executable ../../../bin/kudu
ld.gold: error: cannot find -lsecurity_test_util
collect2: error: ld returned 1 exit status
This is a follow-up to 8595384de007963181cca59b0248b85169f18792.
Change-Id: Ie5bd16c049cb4494856ae872554e79ab0bd4785f
Reviewed-on: http://gerrit.cloudera.org:8080/19761
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5bd16c049cb4494856ae872554e79ab0bd4785f
Gerrit-Change-Number: 19761
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [mini-cluster] fix build if NO TESTS=1
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19761 )
Change subject: [mini-cluster] fix build if NO_TESTS=1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5bd16c049cb4494856ae872554e79ab0bd4785f
Gerrit-Change-Number: 19761
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 03:14:58 +0000
Gerrit-HasComments: No