[GitHub] [calcite] jinxing64 commented on a change in pull request #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching.

[GitBox <gi...@apache.org>]

jinxing64 commented on a change in pull request #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching.
URL: https://github.com/apache/calcite/pull/1307#discussion_r301062652
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
 ##########
 @@ -495,8 +495,9 @@ assert equalType(
     for (MutableRel targetDescendant : targetDescendants) {
       MutableRel queryDescendant = map.get(targetDescendant);
       if (queryDescendant != null) {
-        assert queryDescendant.rowType.equals(targetDescendant.rowType);
-        equivalents.put(queryDescendant, targetDescendant);
 
 Review comment:
   I made this change, because rel like https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/mutable/MutableAggregate.java#L68 can will equal with each other but have different row type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services