The tagged version must be "v0.13.0" (note the v prefix) to be a valid Go module.

[Jens Geyer <je...@hotmail.com>]

What needs to be changed? Where?

*confused*



-----Ursprüngliche Nachricht----- 
From: Duru Can Celasun
Sent: Friday, October 11, 2019 10:23 PM
To: dev@thrift.apache.org
Subject: Re: [VOTE] Apache Thrift 0.13.0-rc0 release candidate

Just a reminder: The tagged version must be "v0.13.0" (note the v prefix) to 
be a valid Go module.

I've verified the signature & checksums for the tar.gz.


On Fri, 11 Oct 2019, at 21:01, Jens Geyer wrote:
> All,
>
> I propose that we accept the following release candidate as the official
> Apache Thrift 0.13.0 release:
>
> https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.tar.gz
>
> The release candidate was created from the release/0.13.0 branch and can 
> be
> cloned using:
>
> git clone -b release/0.13.0 https://github.com/apache/thrift.git
>
> The release candidates GPG signature can be found at:
> https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.tar.gz.asc
>
> The release candidates checksums are:
> md5: 38a27d391a2b03214b444cb13d5664f1
> sha1: 0cbb06d047a8212c6ac1240492bc569609fecd33
> sha256: 7ad348b88033af46ce49148097afe354d513c1fca7c607b59c33ebb6064b5179
>
>
> A prebuilt statically-linked Windows compiler is available at:
> https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.exe
>
> Prebuilt statically-linked Windows compiler GPG signature:
> https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.exe.asc
>
> Prebuilt statically-linked Windows compiler checksums are:
> md5: e6deaa01bc3697fd78beb680417ef45c
> sha1: 317b27dd758fed3dd424be8f6e550e0473bc9584
> sha256: 92753ef860304eb6b3fdbbb3e07ae23b30827194d3c2a072bb4cf7a65be87693
>
>
> The source tree as ZIP file to be published via Github releases:
> https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.zip
>
> ZIP source tree GPG signature:
> https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.zip.asc
>
> ZIP source tree checksums are:
> md5: e30699d2eec0cddf80fd4a50ab6aaf2b
> sha1: 1d56b31aca92f1940701f9a267d8ca473e9b7256
> sha256: 196e52d8fc1a0dd15620ccae59e2473940d41935881608f6eae0c8615366aeb5
>
>
> The CHANGES list for this release is available at:
> https://github.com/apache/thrift/blob/release/0.13.0/CHANGES.md
>
>
> Please download, verify sig/sum, install and test the libraries and
> languages of your choice.
>
> This vote will close in 120 hours on 2019-10-16 20:00 UTC
>
> [ ] +1 Release this as Apache Thrift 0.13.0
> [ ] +0
> [ ] -1 Do not release this as Apache Thrift 0.13.0 because...
>
>
> Have fun,
> JensG
>
> 

Re: The tagged version must be "v0.13.0" (note the v prefix) to be a valid Go module.

[Duru Can Celasun <dc...@apache.org>]

Nothing needs to be changed, sorry for the confusion. What I mean is, when you push the tag to Github [1] it should be exactly v0.13.0, including the "v" prefix otherwise Go's package manager won't pick up the new version.

We only started using the prefix with v0.12.0 so I just wanted make sure it's there for the next release as well.

[1] https://github.com/apache/thrift/tags

On Sat, 12 Oct 2019, at 14:51, Jens Geyer wrote:
> 
> What needs to be changed? Where?
> 
> *confused*
> 
> 
> 
> -----Ursprüngliche Nachricht----- 
> From: Duru Can Celasun
> Sent: Friday, October 11, 2019 10:23 PM
> To: dev@thrift.apache.org
> Subject: Re: [VOTE] Apache Thrift 0.13.0-rc0 release candidate
> 
> Just a reminder: The tagged version must be "v0.13.0" (note the v prefix) to 
> be a valid Go module.
> 
> I've verified the signature & checksums for the tar.gz.
> 
> 
> On Fri, 11 Oct 2019, at 21:01, Jens Geyer wrote:
> > All,
> >
> > I propose that we accept the following release candidate as the official
> > Apache Thrift 0.13.0 release:
> >
> > https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.tar.gz
> >
> > The release candidate was created from the release/0.13.0 branch and can 
> > be
> > cloned using:
> >
> > git clone -b release/0.13.0 https://github.com/apache/thrift.git
> >
> > The release candidates GPG signature can be found at:
> > https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.tar.gz.asc
> >
> > The release candidates checksums are:
> > md5: 38a27d391a2b03214b444cb13d5664f1
> > sha1: 0cbb06d047a8212c6ac1240492bc569609fecd33
> > sha256: 7ad348b88033af46ce49148097afe354d513c1fca7c607b59c33ebb6064b5179
> >
> >
> > A prebuilt statically-linked Windows compiler is available at:
> > https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.exe
> >
> > Prebuilt statically-linked Windows compiler GPG signature:
> > https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.exe.asc
> >
> > Prebuilt statically-linked Windows compiler checksums are:
> > md5: e6deaa01bc3697fd78beb680417ef45c
> > sha1: 317b27dd758fed3dd424be8f6e550e0473bc9584
> > sha256: 92753ef860304eb6b3fdbbb3e07ae23b30827194d3c2a072bb4cf7a65be87693
> >
> >
> > The source tree as ZIP file to be published via Github releases:
> > https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.zip
> >
> > ZIP source tree GPG signature:
> > https://dist.apache.org/repos/dist/dev/thrift/0.13.0-rc0/thrift-0.13.0-rc0.zip.asc
> >
> > ZIP source tree checksums are:
> > md5: e30699d2eec0cddf80fd4a50ab6aaf2b
> > sha1: 1d56b31aca92f1940701f9a267d8ca473e9b7256
> > sha256: 196e52d8fc1a0dd15620ccae59e2473940d41935881608f6eae0c8615366aeb5
> >
> >
> > The CHANGES list for this release is available at:
> > https://github.com/apache/thrift/blob/release/0.13.0/CHANGES.md
> >
> >
> > Please download, verify sig/sum, install and test the libraries and
> > languages of your choice.
> >
> > This vote will close in 120 hours on 2019-10-16 20:00 UTC
> >
> > [ ] +1 Release this as Apache Thrift 0.13.0
> > [ ] +0
> > [ ] -1 Do not release this as Apache Thrift 0.13.0 because...
> >
> >
> > Have fun,
> > JensG
> >
> > 
> 
>