[GitHub] [spark] wangyum commented on a change in pull request #29641: [SPARK-32791][SQL] Non-partitioned table metric should not have dynamic partition pruning time

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #29641:
URL: https://github.com/apache/spark/pull/29641#discussion_r483960837



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -384,6 +386,7 @@ abstract class DynamicPartitionPruningSuiteBase
         assert(scan3.metrics("numFiles").value == partFilesNum)
         assert(scan3.metrics("filesSize").value == partFilesSize)
         assert(scan3.metrics("numPartitions").value === 1)
+        assert(scan3.metrics("pruningTime").value !== -1)

Review comment:
       Using `!==`would give more informative error message:
   https://www.scalatest.org/getting_started_with_fun_suite




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org