You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/02/02 20:47:11 UTC

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9199


Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................

KUDU-2281: Add Primary Key Support For INT128 Columns

Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
---
M src/kudu/client/predicate-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/key_util-test.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/all_types-itest.cc
10 files changed, 84 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9199/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 )

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/encoded_key-test.cc
File src/kudu/common/encoded_key-test.cc:

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/encoded_key-test.cc@178
PS3, Line 178:     EXPECT_DECODED_KEY_EQ(INT128, "(int128 key=170141183460469231731687303715884105727)",
Add a negative value test case.


http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/key_encoder.h
File src/kudu/common/key_encoder.h:

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/key_encoder.h@94
PS3, Line 94: uint128_t
It may be better to do static_cast<unsigned_cpp_type>(1) here, so that it doesn't use 128bit intermediate types for int8, int32, etc.  Not sure if that would cause a performance difference, but seems simpler to just avoid it entirely anyways.


http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/key_encoder.h@116
PS3, Line 116:       val ^= static_cast<uint128_t>(1) << (sizeof(val) * CHAR_BIT - 1);
likewise


http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/integration-tests/all_types-itest.cc
File src/kudu/integration-tests/all_types-itest.cc:

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/integration-tests/all_types-itest.cc@291
PS3, Line 291:     builder.AddColumn("decimal_val")->Type(KuduColumnSchema::DECIMAL)
Perhaps this should have a decimal column from each size bucket?



-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 05 Feb 2018 16:26:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9199

to look at the new patch set (#4).

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................

KUDU-2281: Add Primary Key Support For INT128 Columns

Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
---
M src/kudu/client/predicate-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/key_util-test.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/all_types-itest.cc
10 files changed, 125 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9199/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 )

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 05 Feb 2018 20:33:17 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 )

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 05 Feb 2018 18:58:52 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 )

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/key_encoder.h
File src/kudu/common/key_encoder.h:

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/key_encoder.h@94
PS3, Line 94: 
> It may be better to do static_cast<unsigned_cpp_type>(1) here, so that it d
Done


http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/common/key_encoder.h@116
PS3, Line 116:     }
> likewise
Done


http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/integration-tests/all_types-itest.cc
File src/kudu/integration-tests/all_types-itest.cc:

http://gerrit.cloudera.org:8080/#/c/9199/3/src/kudu/integration-tests/all_types-itest.cc@291
PS3, Line 291:     builder.AddColumn("decimal32_val")->Type(KuduColumnSchema::DECIMAL)
> Perhaps this should have a decimal column from each size bucket?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 05 Feb 2018 18:47:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 )

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................


Patch Set 6:

Added back Dan's +2 after a negligible lint fix.


-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 05 Feb 2018 20:33:39 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9199 )

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................

KUDU-2281: Add Primary Key Support For INT128 Columns

Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Reviewed-on: http://gerrit.cloudera.org:8080/9199
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@gmail.com>
---
M src/kudu/client/predicate-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/key_util-test.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/all_types-itest.cc
10 files changed, 128 insertions(+), 16 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9199

to look at the new patch set (#6).

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................

KUDU-2281: Add Primary Key Support For INT128 Columns

Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
---
M src/kudu/client/predicate-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/key_util-test.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/all_types-itest.cc
10 files changed, 128 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9199/6
-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9199

to look at the new patch set (#3).

Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns
......................................................................

KUDU-2281: Add Primary Key Support For INT128 Columns

Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
---
M src/kudu/client/predicate-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/key_util-test.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/all_types-itest.cc
10 files changed, 85 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9199/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6aadca2c5207f397ef6bdde4462a7497fea8ccd
Gerrit-Change-Number: 9199
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot