You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hrsakai (via GitHub)" <gi...@apache.org> on 2023/12/07 23:53:51 UTC
[PR] Add type definition for AthenzX509Config [pulsar-client-node]
hrsakai opened a new pull request, #358:
URL: https://github.com/apache/pulsar-client-node/pull/358
### Motivation
Athenz support x.509 certificate and `tokenExpirationTime` param has been removed at https://github.com/apache/pulsar-client-cpp/pull/274 .
### Modifications
* Add type definition for athen x.509 certificate
* Mark tokenExpirationTime as deprecated
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add type definition for AthenzX509Config [pulsar-client-node]
Posted by "massakam (via GitHub)" <gi...@apache.org>.
massakam merged PR #358:
URL: https://github.com/apache/pulsar-client-node/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add type definition for AthenzX509Config [pulsar-client-node]
Posted by "massakam (via GitHub)" <gi...@apache.org>.
massakam commented on PR #358:
URL: https://github.com/apache/pulsar-client-node/pull/358#issuecomment-1846557673
I think the following page needs to be updated, so I'll label it as `doc-required`.
https://pulsar.apache.org/docs/next/security-athenz/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add type definition for AthenzX509Config [pulsar-client-node]
Posted by "massakam (via GitHub)" <gi...@apache.org>.
massakam commented on PR #358:
URL: https://github.com/apache/pulsar-client-node/pull/358#issuecomment-1853127316
The document has been updated by https://github.com/apache/pulsar-site/pull/747.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org