You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gsmiller (via GitHub)" <gi...@apache.org> on 2023/05/21 02:57:06 UTC
[GitHub] [lucene] gsmiller opened a new issue, #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
gsmiller opened a new issue, #12321:
URL: https://github.com/apache/lucene/issues/12321
### Description
There's some good suggestions/discussion around renaming this class in #12310, but I wonder if we should consider making it pkg-private and exposing the `build` functionality through `Automata` instead? We already do this with `Automata#makeStringUnion`, so maybe we could shrink our API footprint and consolidate everything behind `Automata`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on issue #12321:
URL: https://github.com/apache/lucene/issues/12321#issuecomment-1561336041
Yes, yes, yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller closed issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller closed issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
URL: https://github.com/apache/lucene/issues/12321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on issue #12321:
URL: https://github.com/apache/lucene/issues/12321#issuecomment-1564712751
Merged on `main` (#12331) and also added some deprecation notices on 9.x (#12332).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on issue #12321:
URL: https://github.com/apache/lucene/issues/12321#issuecomment-1561084897
Thanks @mikemccand. I'll take this up after #12320, unless someone else jumps on it first. I'd like to keep it separate from the changes in #12320 to avoid putting too much in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on issue #12321:
URL: https://github.com/apache/lucene/issues/12321#issuecomment-1561325622
nice idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on issue #12321:
URL: https://github.com/apache/lucene/issues/12321#issuecomment-1563232821
Actually, on second thought, this will be easy to resolve with the other PR I'm working on (#12320), so I'll go ahead with a PR. Here we go: #12331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on issue #12321: Can we make `DaciukMihovAutomatonBuilder` pkg-private?
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on issue #12321:
URL: https://github.com/apache/lucene/issues/12321#issuecomment-1559085083
Oooh I love that idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org