You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/03 23:23:07 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26148: Use proper default airflow_constraints_reference
potiuk opened a new pull request, #26148:
URL: https://github.com/apache/airflow/pull/26148
In case image was built by `breeze` and not by `build` command.
default value of the arg was wrong (empty) rather than default
constraint branch. That led to early cache invalidation and much
longer image build than necessary.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #26148: Use proper default airflow_constraints_reference
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on PR #26148:
URL: https://github.com/apache/airflow/pull/26148#issuecomment-1244022196
> cc: @o-nikolas @mik-laj -> this was another reason for longer builds than necessary (but only when plain `breeze` command was used. When you did `breeze ci-image build` or old `breeze build-image` - it was fast, but when you run `breeze` and chose to build image, the build could have taken longer because of this small bug,
I'm late to this party since I was on vacation, but this is awesome! Thanks for doubling down on speeding up Airflow builds @potiuk :+1: :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26148: Use proper default airflow_constraints_reference
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26148:
URL: https://github.com/apache/airflow/pull/26148#issuecomment-1236212917
cc: @o-nikolas @mik-laj -> this was another reason for longer builds than necessary (but only when plain `breeze` command was used. When you did `breeze ci-image build` or old `breeze build-image` - it was fast, but when you run `breeze` and chose to build image, the build could have taken longer because of this small bug,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26148: Use proper default airflow_constraints_reference
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26148:
URL: https://github.com/apache/airflow/pull/26148#issuecomment-1244058565
> I'm late to this party since I was on vacation, but this is awesome! Thanks for doubling down on speeding up Airflow builds @potiuk 👍 😄
Yeah. I think I **finally** nailed all the edge cases for the builds that caused occasional (but extremely annoying) cases where the image was built for a longer time than needed. I have not seen recently any case where things are taking long time and also once we merge the last fix: https://github.com/apache/airflow/pull/26351 ( just realized we had a bug there while answering this comment) we have an actual CI test in our "canary" builds that test if the build is "quick" - so we should have an early warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26148: Use proper default airflow_constraints_reference
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26148:
URL: https://github.com/apache/airflow/pull/26148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26148: Use proper default airflow_constraints_reference
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26148:
URL: https://github.com/apache/airflow/pull/26148#issuecomment-1236295487
Also added CI test that will give us an early warning in case of our "canary" builds in main in #26150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26148: Use proper default airflow_constraints_reference
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26148:
URL: https://github.com/apache/airflow/pull/26148#issuecomment-1236213017
After we merge this one, I think all of the problems with "sometimes longer build than needed" should be solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org